This repository has been archived by the owner on Dec 15, 2022. It is now read-only.
Close remote buffers on guest when host closes portal #319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
|
@as-cii: I think this is almost ready to merge, but there's one regression that I'm observing: Prior to this pull request, when the host closes the portal, the guest sees a notification saying that the portal was closed. With the changes in this pull request, the guest no longer sees that notification; they just see all the remote tabs get closed. I think it's important for Teletype to show this notification, so that the guest understands why the tabs were closed. I haven't yet had a chance to look into addressing this regression, but I think that's the next step for moving forward with this pull request. |
Co-authored-by: Jason Rudolph <jason@jasonrudolph.com>
1e002eb to
ca0873f
Compare
This fixes a regression introduced in the previous commit that was causing notification to not appear when host closed the portal or lost the connection. Specifically, these notifications were not appearing because GuestPortalBinding interpreted closing remote tabs as being a user-initiated action, instead of as a result of the host tearing down their portal. Thus, when the last tab was being closed the guest would mistakenly leave the portal instead of being kicked out of it. With this commit we rely on when `editorBinding.onDidDispose` is fired to determine if the editor was destroyed manually or by the host. In particular, if `onDidDispose` is called before actually destroying the pane item associated with the editor, it means that `EditorProxy.dispose` was called first and the host wanted to tear down that particular editor. Otherwise, if we haven't processed the binding `onDidDispose` event when an editor is destroyed it means the editor was destroyed by the user.
ca0873f to
ecdd3bf
Compare
jasonrudolph
added a commit
that referenced
this pull request
Feb 8, 2018
Prior to #319, when the host closed the portal, Teletype would transform the remote editors in the guest's workspace into local untitled/unsaved editors. As of #319, when the host closed the portal, Teletype *closes* remote editors in the guest's workspace. As a result, we no longer need the logic for transforming the remote editors into local editors.
2 tasks
|
A quick before-and-after demo of the guest's experience when the host closes the portal: Before: So many tabs to close 🙀
After: Such a clean workspace 🧘♂️
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
This change addresses the following item from the task list in #268:
In the discussion in 9d9f74c#commitcomment-26310833, we observed that it's often "annoying that the host's buffers persist as unsaved files after they close their portal. With one editor, it was fine, but now there are quite a few tabs to clean up after a host terminates their session." With the changes in this pull request, when the host closes the portal, Teletype will clean up the guest's workspace to remove the closed portal's tabs.
Verification Process