This repository has been archived by the owner on Dec 15, 2022. It is now read-only.
Authentication, Part 1 #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also update LocalRestGateway::get to support passing query parameters.
For backwards compatibility with existing clients, we'll initially roll this out in a way that uses the OAuth token if it's present and ignores it if it's not present.
nathansobo
reviewed
Aug 25, 2017
| const error = JSON.parse(e.error) | ||
| const description = (error.message != null) ? error.message : e.error | ||
| const reason = `GitHub API responded with ${e.statusCode}: ${description}` | ||
| return Promise.reject(reason) |
There was a problem hiding this comment.
Since this function is async you could also rethrow here. I guess the semantics are identical but I was a bit confused by the return at first since async is an abstraction over promises, so we're sort of mixing two levels of abstraction by explicitly returning one.
|
Looks pretty! |
15 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the initial functionality needed to fetch the GitHub identity for each participant in a portal. I'll plan a follow up PR 🔜 to:
TODOitems introduced in this PR