This repository has been archived by the owner on Dec 15, 2022. It is now read-only.
Mark LaunchModeView as read-only #218
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Heh.... well, feel free to merge it. 🙇 On the other hand, we can also just keep it in the One themes for now. If it's a convention that all packages/themes should follow, we probably should make it part of the API. Currently it's a bit a wild-west where every package adds their own elements, functionality and styling. Having more consistency around it might be nice. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Description of the Change
Because it is. Should remove the need to special-case
status-bar-launch-modein the One themes.Alternate Designs
None.
Benefits
Removal of special-casing in the One themes.
Possible Drawbacks
None.
Applicable Issues
None.
/cc @simurai is this worth doing?