This repository has been archived by the owner on Dec 15, 2022. It is now read-only.
Fix: Check user_name after wchar conversion (Windows) #241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After converting utf8 to wchar, the wrong variable was checked, probably by copy-paste.
shiftkey
approved these changes
Apr 26, 2020
There was a problem hiding this comment.
@hrantzsch apologies, totally missed this!
Great spot - yes, we're not checking the right value here.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Identify the Bug
SetPasswordconverts the providedstd::string accountto a wchar-pointer by means ofutf8ToWideChar. Subsequently, it should check if the conversion was successful.Probably due to copy-paste, it checks
target_name(again) instead.Description of the Change
Check the freshly created
user_nameinstead.Alternate Designs
None
Possible Drawbacks
None
Verification Process
The code compiles.
Release Notes
N/A