Skip to content
This repository has been archived by the owner on Dec 15, 2022. It is now read-only.

Fix engines field in package.json #267

Merged
merged 1 commit into from
Feb 19, 2015
Merged

Fix engines field in package.json #267

merged 1 commit into from
Feb 19, 2015

Conversation

benogle
Copy link
Contributor

@benogle benogle commented Feb 13, 2015

Remove * to reduce confusion, and add make sure atom is less than 2.0.0.

@joefitzgerald
Copy link
Contributor

Oh weird that * was an error.

@joefitzgerald
Copy link
Contributor

@benogle can you help me understand why we would want an upper bound to this? The * should absolutely be removed.

@benogle
Copy link
Contributor Author

benogle commented Feb 19, 2015

This supports only the atom 1.0 api. It's future proofing for 2.0. We can set it and forget it.

benogle added a commit that referenced this pull request Feb 19, 2015
@benogle benogle merged commit 58944e8 into master Feb 19, 2015
@benogle benogle deleted the bo-fix-engines branch February 19, 2015 21:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants