Use proper method to subscribe to onDidTokenize #650
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Way back in atom/atom@117a3fb (released in Atom v1.9.0-beta0) Atom introduced an experimental TextEditor::onDidTokenize method in order to subscribe to that event. Switch to using this instead of grabbing it through the private properties which no longer work as of Atom v1.25.0-beta0. Fixes atom-minimap#649.
|
Note: CI failures are unrelated to this PR and look to have been happening on |
|
Given the popularity of this package it would be really awesome if some of the maintainers could merge and release this patch. ❤️ Thank you in advance! |
|
Reproduced and confirmed the fix. Release incoming. Thanks @Arcanemagus 💯 |
|
Can anyone explain step by step what I can do to fix the minimap display issue in 1.25.0 as I'm not understanding what to do to switch to the TextEditor::onDidTokenize method. |
|
Updating to v4.29.8 should get |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Way back in atom/atom@117a3fb (released in Atom v1.9.0-beta0) Atom introduced an experimental TextEditor::onDidTokenize method in order to subscribe to that event. Switch to using this instead of grabbing it through the private properties which no longer work as of Atom v1.25.0-beta0.
Note that this is still present in the current codebase.
Fixes #649.