Start using new DisplayLayer APIs #474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you @as-cii for taking care of that! I'll give it a look as soon as I come back home. |
|
I mostly fixed issues related to the current version of Atom, I found that some lines disappear when scrolling up (it was reported before but I couldn't reproduce on my config), so I'll investigate that part as well. Anyway, thanks again for the kick off on this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes are an attempt at switching to the new
DisplayLayertext decoration facilities (in a backward compatible manner), which have superseded some deprecated APIs, such astokenizedLineForScreenRow. More informations in the related PR.@abe33: what do you think? I haven't tested this extensively, but definitely feel free to make any change you think would be needed to this branch (it's a fork, so I have given you collaborator access on my version of the repository).
Thanks! 🙇