-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uncaught TypeError: Invalid Point: (NaN, 0) #626
Comments
This is easily reproducible for me when ever you right click on a tab and choose "split left", no split happens but when I restart the split is now visible |
[Enter steps to reproduce:]
Atom: 1.19.3 x64 Stack TraceUncaught TypeError: Invalid Point: (NaN, 0)
Commands
Non-Core Packages
|
I received this ("Uncaught TypeError: Invalid Point: (NaN, 0) thrown from minimap package") error when trying to use shortcut key to bring up a list of projects in the Package Manager package (vs splitting existing pane to a new pane). |
[Enter steps to reproduce:]
Atom: 1.19.4 x64 Stack TraceUncaught TypeError: Invalid Point: (NaN, 0)
Commands
Non-Core Packages
|
Same error on "split left" for tab. When restart, load splited without any issue. |
I use splits frequently and this is really obnoxious. Can this be prioritized for the next release? |
+1 for this error...
|
+1 |
To work around, revert to Atom 1.18 (not so bad). Reverting minimap to older versions does not help. |
+1 |
[Enter steps to reproduce:]
Atom: 1.21.0-beta0 x64 Stack TraceUncaught TypeError: Invalid Point: (NaN, 0)
Commands
Non-Core Packages
|
For me it happens with Split Right from the editor. Split Right in the tree view works fine |
It is a little silly but if I quit and start atom - there ya go the new pane is aliive and well. For now I have disabled minimap. I like it but not when i cannot do multipane editing conveniently. |
Can this issue get locked by moderation? No new information is being shared. Use the reaction buttons to |
I'm trying to reproduce this and I'm having trouble. I use minimap daily (with atom-beta, 1.21-0 as of now) and I've not seen this issue. I've tried splitting left/right in various ways, from the tree view or from a tab. I've tried using project manager and switching projects (sometimes that can corrupt state in weird ways) and doing this. I'm afraid it's hard to help without a reliable reproduction. Regardless.. from pure guesswork, we appear to have a data race going on, though it doesn't appear to be a problem with minimap. The problem appears to be that sometimes I filed #633 as an attempt to fix this. Can someone that gets this issue use that branch locally and let me know if it fixes the issue? $ git clone https://github.com/atom-minimap/minimap
$ cd minimap
$ git checkout mehcode-possible-fix-626
$ npm i
$ apm link . |
I keep the latest general and the latest beta available. Usually I run the beta if I can tell the difference ( :) ) 1.19.7 and 1.20beta7 both reliably exhibited this issue. Race Conditions can be frustrating to find. Un-documented APIs and fun when they work and nasty when they don't. I try to never use them. |
I have had this issue occur in 1.20.0 |
Shows how hard this can be :( |
Got another report for you. Link: https://hastebin.com/xumetegore.md It's consistently occurring in atom 1.20.0 whenever I press backspace or enter near |
@mehcode Sure! I don't know how to install that version though. |
Read the comment above for instructions: #626 (comment) You'll need to uninstall your current version first. |
@mark-hahn Thanks! Didn't see that :P Got an error though on the
|
@sbrl Didn't edit my post fast enough. 🙂 You'll need to have your version uninstalled first. Either from the UI or:
|
I tried to install
Here is the log file
I am able to reproduce the issue on command by doing the following:
Minimap has to be active at the time of the split. At this point the only way to recover is to restart Atom. If there is an easy fix to the NPM issue then I should be able to verify the fix is working. Just not sure the correct fix. Running Atom 1.20.0 x64 on Mac.
|
@mehcode mehcode-possible-fix-626 work for me,thx! |
@HaoranW Thank you for confirming that |
Released v4.29.7 with the fix. Let us know if this is still an issue. |
The fix seems to be solid on my end. 👍 |
Sorry I haven't had time to check into this! Yeah, that fix does the job for me too 😺 |
[Enter steps to reproduce:]
Atom: 1.20.0-beta3 x64
Electron: 1.6.9
OS: linux 4.12.6-1-ARCH
Thrown From: minimap-plus package 4.29.2
Stack Trace
Uncaught TypeError: Invalid Point: (NaN, 0)
Commands
Non-Core Packages
The text was updated successfully, but these errors were encountered: