-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stopped working in 0.177.0 #256
Comments
It's working on my machine. Disable other plugins and try again. |
FWIW have you tried disabling the hardware acceleration? |
I tried both disabling all other (community) plugins, and disabled hardware acceleration, and it still doesn't work. Any other ideas? I love this plugin... |
@thislooksfun Thanks reporting. Maybe it's same as #255. You can try this branch #258 |
@thislooksfun Update to the latest version(v4.1.2). |
Nope. Still doesn't work. I'm going to try re-installing it. |
Good catch! Thanks @thislooksfun |
No problem! Just a fair amount of trial and error. Not like I had anything better to do. :P |
I'm trying to fix that. |
@thislooksfun Can you try this branch? https://github.com/fundon/atom-minimap/tree/fix/soft_wrap_at_preferred_line_length |
…ength fix softWrapAtPreferredLineLength bug, #256
Fixed in v4.1.3. |
If it's still same issue, re-open it. |
It appears to be working now. However, I have also found that having the line length that high is a bad idea on it's own. Scrolling gets really slow. Thanks for fixing it though! Keep up the great work! |
I should have seen it coming. We'll need to make sure the minimap canvas width never get this wide so that we avoid memory or performance hog. @fundon If you have some time to write the tests corresponding to the fix so that we don't miss it the next time we touch the codebase. |
@abe33 You are right 👍 , sorry. I will. :) |
After updating to Atom 0.177.0 and Minimap 4.1.0, the minimap stopped working.
Settings:
Screenshot:
It's probably something I have done, but I see no reason why it wouldn't be working.
The text was updated successfully, but these errors were encountered: