fix: add activation hook

atom-minimap · Nov 21, 2020 · ee3e5d7 · ee3e5d7
1 parent 4d3ef9f
commit ee3e5d7
Show file tree

Hide file tree

Showing 3 changed files with 20 additions and 0 deletions.
diff --git a/package.json b/package.json
@@ -40,6 +40,9 @@
   "viewProviders": [
     "minimapViewProvider"
   ],
+  "activationHooks": [
+    "core:loaded-shell-environment"
+  ],
   "configSchema": {
     "plugins": {
       "type": "object",

diff --git a/spec/minimap-element-spec.js b/spec/minimap-element-spec.js
@@ -52,6 +52,11 @@ describe('MinimapElement', () => {
       ? document.body.querySelector('#jasmine-content')
       : document.body
 
+
+    // Package activation will be deferred to the configured, activation hook, which is then triggered
+    // Activate activation hook
+    atom.packages.triggerDeferredActivationHooks();
+    atom.packages.triggerActivationHook("core:loaded-shell-environment");
     waitsForPromise(() => atom.packages.activatePackage('minimap'))
 
     runs(() => {
@@ -1949,6 +1954,10 @@ describe('MinimapElement', () => {
       describe('with plugins registered in the package', () => {
         let [minimapPackage, pluginA, pluginB] = []
         beforeEach(() => {
+          // Package activation will be deferred to the configured, activation hook, which is then triggered
+          // Activate activation hook
+          atom.packages.triggerDeferredActivationHooks();
+          atom.packages.triggerActivationHook("core:loaded-shell-environment");
           waitsForPromise(() => {
             return atom.packages.activatePackage('minimap').then((pkg) => {
               minimapPackage = pkg.mainModule

diff --git a/spec/minimap-main-spec.js b/spec/minimap-main-spec.js
@@ -16,6 +16,10 @@ describe('Minimap package', () => {
       return atom.workspace.open('sample.coffee')
     })
 
+    // Package activation will be deferred to the configured, activation hook, which is then triggered
+    // Activate activation hook
+    atom.packages.triggerDeferredActivationHooks();
+    atom.packages.triggerActivationHook("core:loaded-shell-environment");
     waitsForPromise(() => {
       return atom.packages.activatePackage('minimap').then((pkg) => {
         minimapPackage = pkg.mainModule
@@ -66,6 +70,10 @@ describe('Minimap package', () => {
           const m = new Minimap({textEditor: editor})
           const v = atom.views.getView(m)
           editorElement.appendChild(v)
+          // Package activation will be deferred to the configured, activation hook, which is then triggered
+          // Activate activation hook
+          atom.packages.triggerDeferredActivationHooks();
+          atom.packages.triggerActivationHook("core:loaded-shell-environment");
           waitsForPromise(() => atom.packages.activatePackage('minimap'))
         })