fix: make getTime a free function

Removes unused getTime spy
atom-minimap · Dec 29, 2020 · ebf816a · ebf816a
1 parent 2f9392a
commit ebf816a
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 31 deletions.
diff --git a/lib/minimap-element.js b/lib/minimap-element.js
@@ -1326,16 +1326,6 @@ class MinimapElement {
     }
   }
 
-  /**
-   * A method that return the current time as a Date.
-   *
-   * That method exist so that we can mock it in tests.
-   *
-   * @return {Date} the current time as Date
-   * @access private
-   */
-  getTime () { return new Date() }
-
   /**
    * A method that mimic the jQuery `animate` method and used to animate the
    * scroll when clicking on the MinimapElement canvas.
@@ -1348,7 +1338,7 @@ class MinimapElement {
    * @access private
    */
   animate ({ from, to, duration, step }) {
-    const start = this.getTime()
+    const start = getTime()
     let progress
 
     const swing = function (progress) {
@@ -1358,7 +1348,7 @@ class MinimapElement {
     const update = () => {
       if (!this.minimap) { return }
 
-      const passed = this.getTime() - start
+      const passed = getTime() - start
       if (duration === 0) {
         progress = 1
       } else {
@@ -1378,3 +1368,13 @@ class MinimapElement {
 
 const minimapElement = MinimapElement.initClass()
 export default minimapElement
+
+/**
+ * A method that return the current time as a Date.
+ *
+ * That method exist so that we can mock it in tests.
+ *
+ * @return {Date} the current time as Date
+ * @access private
+ */
+function getTime () { return new Date() }
diff --git a/spec/minimap-element-spec.js b/spec/minimap-element-spec.js
@@ -782,12 +782,6 @@ describe('MinimapElement', () => {
         let canvas
 
         beforeEach(() => {
-          let t = 0
-          spyOn(minimapElement, 'getTime').andCallFake(() => {
-            const n = t
-            t += 100
-            return n
-          })
           spyOn(minimapElement, 'requestUpdate').andCallFake(() => {})
 
           atom.config.set('minimap.scrollAnimation', false)
@@ -828,12 +822,6 @@ describe('MinimapElement', () => {
         let canvas
 
         beforeEach(() => {
-          let t = 0
-          spyOn(minimapElement, 'getTime').andCallFake(() => {
-            const n = t
-            t += 100
-            return n
-          })
           spyOn(minimapElement, 'requestUpdate').andCallFake(() => {})
 
           atom.config.set('minimap.scrollAnimation', true)
@@ -1137,13 +1125,6 @@ describe('MinimapElement', () => {
       describe('pressing the mouse on the minimap canvas', () => {
         beforeEach(() => {
           jasmineContent.appendChild(minimapElement)
-
-          let t = 0
-          spyOn(minimapElement, 'getTime').andCallFake(() => {
-            const n = t
-            t += 100
-            return n
-          })
           spyOn(minimapElement, 'requestUpdate').andCallFake(() => {})
 
           atom.config.set('minimap.scrollAnimation', false)