Skip to content

Commit

Permalink
fix: use imports + use Array.isArray
Browse files Browse the repository at this point in the history
  • Loading branch information
aminya committed Dec 26, 2020
1 parent 018ae7a commit a262bfb
Show file tree
Hide file tree
Showing 11 changed files with 47 additions and 46 deletions.
5 changes: 2 additions & 3 deletions lib/decoration.js
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
'use strict'

const _ = require('underscore-plus')
const { Emitter } = require('atom')
import { Emitter } from 'atom'

let idCounter = 0
const nextId = function () { return idCounter++ }
Expand All @@ -21,7 +20,7 @@ export default class Decoration {
* @return {boolean} whether the decoration properties match the type
*/
static isType (decorationProperties, type) {
if (_.isArray(decorationProperties.type)) {
if (Array.isArray(decorationProperties.type)) {
if (decorationProperties.type.indexOf(type) >= 0) { return true }
return false
} else {
Expand Down
2 changes: 1 addition & 1 deletion lib/decorators/element.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
'use strict'

const { registerOrUpdateElement } = require('atom-utils-plus')
import { registerOrUpdateElement } from 'atom-utils-plus'

/**
* Generates a decorator function to convert a class into a custom element
Expand Down
15 changes: 7 additions & 8 deletions lib/main.js
Original file line number Diff line number Diff line change
@@ -1,13 +1,12 @@
'use strict'

import include from './decorators/include'
import PluginManagement from './mixins/plugin-management'

const include = require('./decorators/include')
const PluginManagement = require('./mixins/plugin-management')

const { Emitter, CompositeDisposable } = require('atom')
const MinimapElement = require('./minimap-element')
const Minimap = require('./minimap')
const MinimapPluginGeneratorElement = require('./minimap-plugin-generator-element')
import { Emitter, CompositeDisposable } from 'atom'
import MinimapElement from './minimap-element'
import Minimap from './minimap'
import MinimapPluginGeneratorElement from './minimap-plugin-generator-element'

/**
* The `Minimap` package provides an eagle-eye view of text buffers.
Expand Down Expand Up @@ -381,6 +380,6 @@ Main.initClass()
*
* @access private
*/
const main = new Main()
const main = new Main()

export default main
19 changes: 11 additions & 8 deletions lib/minimap-element.js
Original file line number Diff line number Diff line change
@@ -1,13 +1,16 @@
'use strict'

const { CompositeDisposable, Disposable } = require('atom')
const { EventsDelegation, AncestorsMethods } = require('atom-utils-plus')
const DOMStylesReader = require('./mixins/dom-styles-reader')
const CanvasDrawer = require('./mixins/canvas-drawer')
const include = require('./decorators/include')
const element = require('./decorators/element')
const elementResizeDetector = require('element-resize-detector')({ strategy: 'scroll' })
const MinimapQuickSettingsElement = require('./minimap-quick-settings-element')
import { CompositeDisposable, Disposable } from 'atom'
import { EventsDelegation, AncestorsMethods } from 'atom-utils-plus'
import elementResizeDetectorImport from 'element-resize-detector'

import DOMStylesReader from './mixins/dom-styles-reader'
import CanvasDrawer from './mixins/canvas-drawer'
import include from './decorators/include'
import element from './decorators/element'

import MinimapQuickSettingsElement from './minimap-quick-settings-element'
const elementResizeDetector = elementResizeDetectorImport({ strategy: 'scroll' })

let overlayStyle
let Main // TODO: lazy loaded because of race confitions
Expand Down
10 changes: 5 additions & 5 deletions lib/minimap-plugin-generator-element.js
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
'use strict'

const _ = require('underscore-plus')
const fs = require('fs-plus')
const path = require('path')
const { BufferedProcess } = require('atom')
const element = require('./decorators/element')
import _ from 'underscore-plus'
import fs from 'fs-plus'
import path from 'path'
import { BufferedProcess } from 'atom'
import element from './decorators/element'

/**
* @access private
Expand Down
10 changes: 5 additions & 5 deletions lib/minimap-quick-settings-element.js
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
'use strict'

const { CompositeDisposable, Emitter } = require('atom')
const { EventsDelegation, SpacePenDSL } = require('atom-utils-plus')
import { CompositeDisposable, Emitter } from 'atom'
import { EventsDelegation, SpacePenDSL } from 'atom-utils-plus'

const Main = require('./main')
const element = require('./decorators/element')
const include = require('./decorators/include')
import * as Main from './main'
import element from './decorators/element'
import include from './decorators/include'

/**
* @access private
Expand Down
10 changes: 5 additions & 5 deletions lib/minimap.js
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
'use strict'

const include = require('./decorators/include')
const DecorationManagement = require('./mixins/decoration-management')
import include from './decorators/include'
import DecorationManagement from './mixins/decoration-management'

const { Emitter, CompositeDisposable } = require('atom')
const StableAdapter = require('./adapters/stable-adapter')
const LegacyAdapter = require('./adapters/legacy-adapter')
import { Emitter, CompositeDisposable } from 'atom'
import StableAdapter from './adapters/stable-adapter'
import LegacyAdapter from './adapters/legacy-adapter'

let nextModelId = 1

Expand Down
8 changes: 4 additions & 4 deletions lib/mixins/canvas-drawer.js
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
'use strict'

const _ = require('underscore-plus')
const Mixin = require('mixto')
import { escapeRegExp } from 'underscore-plus'
import Mixin from 'mixto'

const CanvasLayer = require('../canvas-layer')
import CanvasLayer from '../canvas-layer'

let Main // TODO: lazy loaded because of race confitions

Expand Down Expand Up @@ -503,7 +503,7 @@ export default class CanvasDrawer extends Mixin {
if (regexp.length !== 0) {
return RegExp(regexp.filter((s) => {
return typeof s === 'string'
}).map(_.escapeRegExp).join('|'), 'g')
}).map(escapeRegExp).join('|'), 'g')
} else {
return null
}
Expand Down
8 changes: 4 additions & 4 deletions lib/mixins/decoration-management.js
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
'use strict'

const { Emitter } = require('atom')
const { escapeRegExp } = require('underscore-plus')
const path = require('path')
const Decoration = require('../decoration')
import { Emitter } from 'atom'
import { escapeRegExp } from 'underscore-plus'
import path from 'path'
import Decoration from '../decoration'

/**
* The mixin that provides the decorations API to the minimap editor
Expand Down
2 changes: 1 addition & 1 deletion lib/mixins/dom-styles-reader.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
'use strict'

const Mixin = require('mixto')
import Mixin from 'mixto'

/**
* This mixin is used by the `CanvasDrawer` in `MinimapElement` to
Expand Down
4 changes: 2 additions & 2 deletions lib/mixins/plugin-management.js
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
'use strict'

const Mixin = require('mixto')
const { CompositeDisposable } = require('atom')
import Mixin from 'mixto'
import { CompositeDisposable } from 'atom'

/**
* Provides methods to manage minimap plugins.
Expand Down

0 comments on commit a262bfb

Please sign in to comment.