fix: remove synchronous lazy loading

In short, there are better ways to improve the startup time

- Loading built-in package has no effect the loading time of the pacakge
- Tree shaking by Parcel is more effective than synchronous lazy
loading.
- A lot of these loadins were duplicate. Once a package is loaded, Node
will cache it. No need to lazy load

lib/canvas-layer.js

@@ -11,7 +11,7 @@ module.exports = class CanvasLayer {
      */
     this.canvas = document.createElement('canvas')
 
-    const desynchronized = process.platform !== "linux"
+    const desynchronized = process.platform !== 'linux'
 
     /**
      * The onscreen canvas context.

lib/main.js

@@ -16,7 +16,10 @@ if (!atom.inSpecMode()) {
 const include = require('./decorators/include')
 const PluginManagement = require('./mixins/plugin-management')
 
-let Emitter, CompositeDisposable, Minimap, MinimapElement, MinimapPluginGeneratorElement
+const { Emitter, CompositeDisposable } = require('atom')
+const MinimapElement = require('./minimap-element')
+const Minimap = require('./minimap')
+const MinimapPluginGeneratorElement = require('./minimap-plugin-generator-element')
 
 /**
  * The `Minimap` package provides an eagle-eye view of text buffers.
@@ -37,8 +40,6 @@ class Main {
    * @access private
    */
   constructor () {
-    if (!Emitter) { ({ Emitter, CompositeDisposable } = require('atom')) }
-
     /**
      * The activation state of the package.
      *
@@ -92,7 +93,6 @@ class Main {
    */
   activate () {
     if (this.active) { return }
-    if (!CompositeDisposable) { ({ Emitter, CompositeDisposable } = require('atom')) }
 
     this.subscriptionsOfCommands = atom.commands.add('atom-workspace', {
       'minimap:toggle': () => {
@@ -123,11 +123,7 @@ class Main {
    * @return {MinimapElement}
    */
   minimapViewProvider (model) {
-    if (!Minimap) { Minimap = require('./minimap') }
-
     if (model instanceof Minimap) {
-      if (!MinimapElement) { MinimapElement = require('./minimap-element') }
-
       const element = new MinimapElement()
       element.setModel(model)
       return element
@@ -192,9 +188,6 @@ class Main {
    * @param  {string} template the name of the template to use
    */
   generatePlugin (template) {
-    if (!MinimapPluginGeneratorElement) {
-      MinimapPluginGeneratorElement = require('./minimap-plugin-generator-element')
-    }
     const view = new MinimapPluginGeneratorElement()
     view.template = template
     view.attach()
@@ -293,7 +286,6 @@ class Main {
    * @return {Function} the `Minimap` class constructor
    */
   minimapClass () {
-    if (!Minimap) { Minimap = require('./minimap') }
     return Minimap
   }
 
@@ -323,8 +315,6 @@ class Main {
     let minimap = this.editorsMinimaps.get(textEditor)
 
     if (!minimap) {
-      if (!Minimap) { Minimap = require('./minimap') }
-
       minimap = new Minimap({ textEditor })
       this.editorsMinimaps.set(textEditor, minimap)
 
@@ -347,7 +337,6 @@ class Main {
    */
   standAloneMinimapForEditor (textEditor) {
     if (!textEditor) { return }
-    if (!Minimap) { Minimap = require('./minimap') }
 
     return new Minimap({
       textEditor: textEditor,

lib/minimap-element.js

@@ -1,13 +1,16 @@
 'use strict'
 
+const { CompositeDisposable, Disposable } = require('atom')
 const { EventsDelegation, AncestorsMethods } = require('atom-utils-plus')
 const DOMStylesReader = require('./mixins/dom-styles-reader')
 const CanvasDrawer = require('./mixins/canvas-drawer')
 const include = require('./decorators/include')
 const element = require('./decorators/element')
 const elementResizeDetector = require('element-resize-detector')({ strategy: 'scroll' })
+const MinimapQuickSettingsElement = require('./minimap-quick-settings-element')
+const Main = require('./main')
 
-let Main, MinimapQuickSettingsElement, CompositeDisposable, Disposable, overlayStyle
+let overlayStyle
 
 const ensureOverlayStyle = () => {
   if (!overlayStyle) {
@@ -71,10 +74,6 @@ class MinimapElement {
    * @access private
    */
   createdCallback () {
-    if (!CompositeDisposable) {
-      ({ CompositeDisposable, Disposable } = require('atom'))
-    }
-
     // Core properties
 
     /**
@@ -601,10 +600,6 @@ class MinimapElement {
 
     this.openQuickSettingSubscription = this.subscribeTo(this.openQuickSettings, {
       mousedown: (e) => {
-        if (!MinimapQuickSettingsElement) {
-          MinimapQuickSettingsElement = require('./minimap-quick-settings-element')
-        }
-
         e.preventDefault()
         e.stopPropagation()
 
@@ -687,8 +682,6 @@ class MinimapElement {
    * @return {Minimap} this element's Minimap
    */
   setModel (minimap) {
-    if (!Main) { Main = require('./main') }
-
     this.minimap = minimap
     this.subscriptions.add(this.minimap.onDidChangeScrollTop(() => {
       this.requestUpdate()
@@ -1177,10 +1170,6 @@ class MinimapElement {
    * @access private
    */
   subscribeToMediaQuery () {
-    if (!Disposable) {
-      ({ CompositeDisposable, Disposable } = require('atom'))
-    }
-
     const query = 'screen and (-webkit-min-device-pixel-ratio: 1.5)'
     const mediaQuery = window.matchMedia(query)
     const mediaListener = (e) => { this.requestForcedUpdate() }
@@ -1209,10 +1198,6 @@ class MinimapElement {
    * @access private
    */
   startDrag ({ y, isLeftMouse, isMiddleMouse }) {
-    if (!Disposable) {
-      ({ CompositeDisposable, Disposable } = require('atom'))
-    }
-
     if (!this.minimap) { return }
     if (!isLeftMouse && !isMiddleMouse) { return }
 

lib/minimap.js

@@ -3,7 +3,10 @@
 const include = require('./decorators/include')
 const DecorationManagement = require('./mixins/decoration-management')
 
-let Emitter, CompositeDisposable, LegacyAdapter, StableAdapter
+const { Emitter, CompositeDisposable } = require('atom')
+const StableAdapter = require('./adapters/stable-adapter')
+const LegacyAdapter = require('./adapters/legacy-adapter')
+
 let nextModelId = 1
 
 /**
@@ -37,10 +40,6 @@ class Minimap {
       throw new Error('Cannot create a minimap without an editor')
     }
 
-    if (!Emitter) {
-      ({ Emitter, CompositeDisposable } = require('atom'))
-    }
-
     /**
      * The Minimap's text editor.
      *
@@ -208,14 +207,8 @@ class Minimap {
     this.initializeDecorations()
 
     if (atom.views.getView(this.textEditor).getScrollTop != null) {
-      if (!StableAdapter) {
-        StableAdapter = require('./adapters/stable-adapter')
-      }
       this.adapter = new StableAdapter(this.textEditor)
     } else {
-      if (!LegacyAdapter) {
-        LegacyAdapter = require('./adapters/legacy-adapter')
-      }
       this.adapter = new LegacyAdapter(this.textEditor)
     }
 

lib/mixins/decoration-management.js

@@ -1,6 +1,9 @@
 'use strict'
 
-let _, path, Emitter, Decoration
+const { Emitter } = require('atom')
+const { escapeRegExp } = require('underscore-plus')
+const path = require('path')
+const Decoration = require('../decoration')
 
 /**
  * The mixin that provides the decorations API to the minimap editor
@@ -15,8 +18,6 @@ module.exports = class DecorationManagement {
    */
   initializeDecorations () {
     if (this.emitter == null) {
-      if (!Emitter) { Emitter = require('atom').Emitter }
-
       /**
        * The minimap emitter, lazily created if not created yet.
        * @type {Emitter}
@@ -323,8 +324,6 @@ module.exports = class DecorationManagement {
   decorateMarker (marker, decorationParams) {
     if (this.destroyed || marker == null) { return }
 
-    if (!Decoration) { Decoration = require('../decoration') }
-
     const { id } = marker
 
     if (decorationParams.type === 'highlight') {
@@ -428,13 +427,10 @@ module.exports = class DecorationManagement {
   }
 
   getOriginatorPackageName () {
-    if (!_) { _ = require('underscore-plus') }
-    if (!path) { path = require('path') }
-
     const line = new Error().stack.split('\n')[3]
     const filePath = line.split('(')[1].replace(')', '')
     const re = new RegExp(
-      atom.packages.getPackageDirPaths().join('|') + _.escapeRegExp(path.sep)
+      atom.packages.getPackageDirPaths().join('|') + escapeRegExp(path.sep)
     )
     const plugin = filePath.replace(re, '').split(path.sep)[0].replace(/minimap-|-minimap/, '')
     return plugin.indexOf(path.sep) < 0 ? plugin : undefined

lib/mixins/plugin-management.js

@@ -1,8 +1,7 @@
 'use strict'
 
 const Mixin = require('mixto')
-
-let CompositeDisposable
+const { CompositeDisposable } = require('atom')
 
 /**
  * Provides methods to manage minimap plugins.
@@ -69,10 +68,6 @@ module.exports = class PluginManagement extends Mixin {
    *                              the registration.
    */
   registerPlugin (name, plugin) {
-    if (!CompositeDisposable) {
-      CompositeDisposable = require('atom').CompositeDisposable
-    }
-
     this.plugins[name] = plugin
     this.pluginsSubscriptions[name] = new CompositeDisposable()