🐛 Fix issue where decorations were not properly removed from canvas

This was due to the fact that before we could register the changes the
decoration's range was already changed, registering an improper range
for a repaint

lib/decoration.js

@@ -71,6 +71,8 @@ module.exports = class Decoration {
     this.markerDestroyDisposable = this.marker.onDidDestroy(() => {
       this.destroy()
     })
+
+    this.screenRange = marker.getScreenRange()
   }
 
   /**

lib/minimap-element.js

@@ -715,7 +715,9 @@ class MinimapElement {
 
     this.subscriptions.add(this.minimap.onDidChangeDecorationRange((change) => {
       const {type} = change
-      if (type === 'line' || type === 'highlight-under' || type === 'background-custom') {
+      if (type === 'line' ||
+          type === 'highlight-under' ||
+          type === 'background-custom') {
         this.pendingBackDecorationChanges.push(change)
       } else {
         this.pendingFrontDecorationChanges.push(change)

lib/mixins/decoration-management.js

@@ -353,7 +353,8 @@ module.exports = class DecorationManagement {
     if (this.decorationMarkerChangedSubscriptions[id] == null) {
       this.decorationMarkerChangedSubscriptions[id] =
       marker.onDidChange((event) => {
-        let decorations = this.decorationsByMarkerId[id]
+        const decorations = this.decorationsByMarkerId[id]
+        const screenRange = marker.getScreenRange()
 
         this.invalidateDecorationForScreenRowsCache()
 
@@ -365,6 +366,9 @@ module.exports = class DecorationManagement {
               decoration: decoration,
               event: event
             })
+            this.emitDecorationChanges(decoration.type, decoration)
+
+            decoration.screenRange = screenRange
           }
         }
         let oldStart = event.oldTailScreenPosition
@@ -479,10 +483,7 @@ module.exports = class DecorationManagement {
 
     this.invalidateDecorationForScreenRowsCache()
 
-    const range = {
-      start: decoration.marker.oldTailScreenPosition,
-      end: decoration.marker.oldHeadScreenPosition
-    }
+    const range = decoration.screenRange
     if (!range.start || !range.end) { return }
 
     this.emitRangeChanges(type, range, 0)