fix: require cache param

atom-minimap · Jan 3, 2021 · 69c7354 · 69c7354
1 parent 8f4a87d
commit 69c7354
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/lib/dom-styles-reader.js b/lib/dom-styles-reader.js
@@ -32,11 +32,11 @@ export default class DOMStylesReader {
    *                                to build
    * @param  {string} property the name of the style property to compute
    * @param  {Node} targetNode
-   * @param  {boolean} [cache=true] whether to cache the computed value or not
+   * @param  {boolean} cache whether to cache the computed value or not
    * @return {string} the computed property's value
    * used in CanvasDrawer
    */
-  retrieveStyleFromDom (scopes, property, targetNode, cache = true) {
+  retrieveStyleFromDom (scopes, property, targetNode, cache) {
     const key = scopes.join(' ')
     let cachedData = this.domStylesCache.get(key)
 

diff --git a/spec/minimap-element-spec.js b/spec/minimap-element-spec.js
@@ -233,7 +233,7 @@ describe('MinimapElement', () => {
           })
           runs(() => {
             nextAnimationFrame()
-            expect(minimapElement.DOMStylesReader.retrieveStyleFromDom(['.editor'], 'color'), minimapElement.minimap.getTextEditorElement()).toEqual(`rgb(0, ${0x6d}, ${0x6d})`)
+            expect(minimapElement.DOMStylesReader.retrieveStyleFromDom(['.editor'], 'color', minimapElement.minimap.getTextEditorElement(), true)).toEqual(`rgb(0, ${0x6d}, ${0x6d})`)
           })
         })
       })
@@ -261,7 +261,7 @@ describe('MinimapElement', () => {
           })
           runs(() => {
             nextAnimationFrame()
-            expect(minimapElement.DOMStylesReader.retrieveStyleFromDom(['.editor'], 'color'), minimapElement.minimap.getTextEditorElement()).toEqual(`rgba(0, ${0x6d}, ${0x6d}, 0)`)
+            expect(minimapElement.DOMStylesReader.retrieveStyleFromDom(['.editor'], 'color', minimapElement.minimap.getTextEditorElement(), true)).toEqual(`rgba(0, ${0x6d}, ${0x6d}, 0)`)
           })
         })
       })