🐛 Fix missing DOM cache invalidation when themes are changed

Fixes #250
atom-minimap · Feb 4, 2015 · 333c155 · 333c155
1 parent 389f387
commit 333c155
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 1 deletion.
diff --git a/lib/minimap-element.coffee b/lib/minimap-element.coffee
@@ -30,6 +30,7 @@ class MinimapElement extends HTMLElement
     @initializeContent()
 
     @subscriptions.add atom.themes.onDidChangeActiveThemes =>
+      @invalidateCache()
       @requestForcedUpdate()
 
     @observeConfig

diff --git a/spec/minimap-element-spec.coffee b/spec/minimap-element-spec.coffee
@@ -404,6 +404,20 @@ describe 'MinimapElement', ->
     #    ##    ## ##     ## ##   ### ##        ##  ##    ##
     #     ######   #######  ##    ## ##       ####  ######
 
+    describe 'when the atom them is changed', ->
+      beforeEach ->
+        nextAnimationFrame()
+        spyOn(minimapElement, 'requestForcedUpdate').andCallThrough()
+        spyOn(minimapElement, 'invalidateCache').andCallThrough()
+
+        atom.themes.emitter.emit 'did-change-active-themes'
+
+        waitsFor -> minimapElement.frameRequested
+
+      it 'forces a refresh with cache invalidation', ->
+        expect(minimapElement.requestForcedUpdate).toHaveBeenCalled()
+        expect(minimapElement.invalidateCache).toHaveBeenCalled()
+
     describe 'when minimap.textOpacity is changed', ->
       beforeEach ->
         spyOn(minimapElement, 'requestForcedUpdate').andCallThrough()
@@ -519,7 +533,7 @@ describe 'MinimapElement', ->
           nextAnimationFrame()
 
           atom.config.set 'minimap.minimapScrollIndicator', true
-          
+
           waitsFor -> minimapElement.frameRequested
           runs -> nextAnimationFrame()