Fix documentation about references #309
Conversation
| Annotations: map[string]string{ | ||
| "Secret": "{{" + resSb1 + ":bindsecret#Data.mysecret}}", |
There was a problem hiding this comment.
This test should have been failing but it was not. Bundle was updated to add the missing finalizer (see around line 64) and the reference was not processed. In fact, the reference format is old here - test test should have been updated when the references refactoring was performed. I've expanded this test to assert the bundle conditions to make sure it does not regress in the future. Also checked if all other tests do have the finalizer specified (there is one that does not intentionally - it tests the the finalizer is added).
| ``` | ||
|
|
||
| ## Referring to ServiceBinding outputs | ||
|
|
||
| When Service Catalog processes a ServiceBinding, the output is placed in a Secret | ||
| When Service Catalog processes a `ServiceBinding`, the output is placed in a `Secret` | ||
| (since they might be secret). If they're not secret, it's convenient to directly |
There was a problem hiding this comment.
"they may contain sensitive data"
There was a problem hiding this comment.
This text is originally from James, so I'm confident it is grammatically correct 😛
There was a problem hiding this comment.
Don't trust me! I am super-prone to making mistakes. I type slightly more quickly than I think in most cases.
But I think Nail here is not suggesting a grammatical change, but one which avoids the confusion of Secret vs secret, which I probably wrote just because it amused me. His version is better!
|
@ash2k you need to run |
Fixes #267.