Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated peerDependencies to react@^18 #2429

Merged
merged 1 commit into from
Aug 30, 2022
Merged

Updated peerDependencies to react@^18 #2429

merged 1 commit into from
Aug 30, 2022

Conversation

jankanty
Copy link
Contributor

@jankanty jankanty commented Jul 14, 2022

It solves:
#2416
#2426
#2428

Can we merge it and release new version to npm? I looked at all changes since last release and they were pure documentation.

@atlassian-cla-bot
Copy link

atlassian-cla-bot bot commented Jul 14, 2022

Hooray! All contributors have signed the CLA.

@jankanty
Copy link
Contributor Author

@danieldelcore can you look at circleci and help it pass? Looks like random fail

@stianberg
Copy link

Any news on this? :)

@wladpaiva
Copy link

I'm already using it in production and seems to be working fine. No reason why it should be hold back

@esslamben
Copy link

Any updates on this?

@kaby2201
Copy link

kaby2201 commented Aug 23, 2022

Seems there is no approval at the moment, I added the peer dependencies and published it at
https://www.npmjs.com/package/ledger-react-beautiful-dnd

@danieldelcore danieldelcore self-assigned this Aug 30, 2022
@danieldelcore
Copy link
Collaborator

Hey folks, thanks for your patience on this. Let's merge this one 👍

@danieldelcore danieldelcore merged commit d75f40f into atlassian:master Aug 30, 2022
@jankanty
Copy link
Contributor Author

@danieldelcore would you release new npm version also? Or its done automatically.

@oskarwrobel
Copy link

@jankanty looks like it's done.

@danieldelcore
Copy link
Collaborator

Yep should be good to go, please lmk if it doesn't work

@esslamben
Copy link

Just bumped up the version and all is working. Thank you very much @jankanty @danieldelcore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants