Remove duplicate code in dimension locking example #1637
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The same boolean check is performed twice, once after the other. This cleans up the example for readability and to fix redundancy.
alexreardon
reviewed
Nov 27, 2019
| @@ -191,10 +191,7 @@ export default class TableApp extends Component<AppProps, AppState> { | |||
| }); | |||
|
|
|||
| // dropped outside the list | |||
| if ( | |||
| !result.destination || | |||
| result.destination.index === result.source.index | |||
There was a problem hiding this comment.
It is possible to move an item back into the same spot. The check result.destination.index === result.source.index will exit early if that is the case
There was a problem hiding this comment.
If you check the lines just below it, the same check occurs, making it redundant. https://github.com/atlassian/react-beautiful-dnd/blob/master/stories/src/table/with-dimension-locking.jsx#L194-L204
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The same boolean check is performed twice, once after the other.
This cleans up the example for readability and to fix redundancy.