feat: ajv 8 support #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ext
commented
May 22, 2021
| @@ -1,1941 +1,31 @@ | |||
| { | |||
| "description": "Schema for Atlassian Document Format.", | |||
There was a problem hiding this comment.
This file is changed because it doesn't work properly with ajv 8, at least not in strict mode. It also yields different errors.
It is a simplified version more suitable for test-cases.
ext
commented
May 22, 2021
| @@ -51,6 +51,7 @@ | |||
| "@babel/preset-env": "^7.0.0", | |||
| "@babel/preset-flow": "7.0.0", | |||
| "@changesets/cli": "^1.3.0", | |||
| "ajv": "^8.5.0", | |||
There was a problem hiding this comment.
The current tests runs against ajv 6, it now runs against latest.
In my fork I have opted to test against all versions declared in peerDependencies instead, see test
erunion
added a commit
to readmeio/better-ajv-errors
that referenced
this pull request
Oct 11, 2021
Work based off work from ext on atlassian#92. Co-authored-by: ext <ext-github@sidvind.com>
2 tasks
erunion
added a commit
to readmeio/better-ajv-errors
that referenced
this pull request
Oct 11, 2021
* chore(deps): upgrading deps * feat: adding support for ajv@8 Work based off work from ext on atlassian#92. Co-authored-by: ext <ext-github@sidvind.com> Co-authored-by: ext <ext-github@sidvind.com>
erunion
approved these changes
Oct 14, 2021
|
Thanks for your contribution. Sorry, I have been very busy lately. I'm still looking for someone internally to take over this project. |
This was referenced Nov 3, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #90. Similar to #91 but I don't think that one is enough as it only fixes one instance of the problem.