Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enhancement: better position, clearer text for reaction tooltip #2254

Merged
merged 4 commits into from
Jul 19, 2022
Merged

enhancement: better position, clearer text for reaction tooltip #2254

merged 4 commits into from
Jul 19, 2022

Conversation

shanberg
Copy link
Collaborator

CleanShot 2022-07-18 at 09 08 36@2x

  • Reaction tooltip now linked to whole reaction button
  • Tooltip should neatly concatenate list of users who reacted, ("stuart, jeff, and sid reacted with 👍 "

@shanberg shanberg requested a review from sid597 July 18, 2022 13:09
@vercel
Copy link

vercel bot commented Jul 18, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
athens ✅ Ready (Inspect) Visit Preview Jul 18, 2022 at 10:29PM (UTC)

@shanberg shanberg marked this pull request as ready for review July 18, 2022 15:07
sid597
sid597 approved these changes Jul 19, 2022
View reviewed changes
Copy link
Collaborator

@sid597 sid597 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GG

@sid597 sid597 merged commit e906c82 into athensresearch:main Jul 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sid597 sid597 sid597 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shanberg @sid597