Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Perf-and-fixes #2127

Merged
merged 31 commits into from
Apr 10, 2022
Merged
Changes from 1 commit
Commits
Show all changes
31 commits
Select commit Hold shift + click to select a range
84b0ff0
rfct: reworking linked ref styles
shanberg Apr 4, 2022
31c6c90
Merge branch 'fix-clicking-todo' into polish-references
shanberg Apr 4, 2022
653ccc8
fix: centered daily notes
shanberg Apr 9, 2022
2184c10
rfct: retire stylefy and garden
shanberg Apr 9, 2022
fe6959e
Merge branch 'polish-references' into perf-and-fixes
shanberg Apr 10, 2022
b9b92d6
fix: correct chevron direction in references
shanberg Apr 10, 2022
ec62b0e
improvement: clearer references section
shanberg Apr 10, 2022
9bdf174
fix: misc minor layout issues
shanberg Apr 10, 2022
2fd482b
rfct: no mui in graph
shanberg Apr 10, 2022
0c9e3b3
improvement: right sidebar responds to motion prefs
shanberg Apr 10, 2022
bb0f40d
feat: add new edit icons
shanberg Apr 10, 2022
51fcd03
feat: use new edit icon
shanberg Apr 10, 2022
e4fca23
chore: remove outdated comment
shanberg Apr 10, 2022
04e6bf6
improvement: slight layout fixes to all-pages
shanberg Apr 10, 2022
c824702
improvement: better inlien refs
shanberg Apr 10, 2022
780876d
fix: breadcrumbs allowed to be big again, and checkboxes not broken
shanberg Apr 10, 2022
0266059
fix: breadcrumbs should wrap
shanberg Apr 10, 2022
20e1cbe
rfct: use correct block container styles
shanberg Apr 10, 2022
1cd833f
rfct: use correct block container styles
shanberg Apr 10, 2022
217d1af
revert: back out of reducedmotion for sidebar to fix expansion issue
shanberg Apr 10, 2022
eb02b0a
fix: node page button shouldn't squish
shanberg Apr 10, 2022
c15679e
fix: block toggle and anchor properly sized
shanberg Apr 10, 2022
5bdede1
fix: passing more tests
shanberg Apr 10, 2022
4f4cb42
chore: happy little comment around fragile styles
shanberg Apr 10, 2022
ae5dbae
fix: embeds only as broken as on release
shanberg Apr 10, 2022
648b75d
improvement: better error language for broken block
shanberg Apr 10, 2022
693a67a
improvement: cleaner style for inline refs
shanberg Apr 10, 2022
8ab8636
rfct: chakra window icons
shanberg Apr 10, 2022
cc1bfd5
rfct: replace material icons on node page
shanberg Apr 10, 2022
95dc4bb
rfct: replace and remove material-ui
shanberg Apr 10, 2022
6dc3771
chore: linting fixes
shanberg Apr 10, 2022
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
improvement: better error language for broken block
shanberg committed Apr 10, 2022
commit 648b75d749913661c445873c192863172de138a7
4 changes: 3 additions & 1 deletion src/js/components/Block/components/Container.tsx
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
import { Box } from "@chakra-ui/react";
import { withErrorBoundary } from "react-error-boundary";

const ERROR_MESSAGE = "An error occurred while rendering this block.";

const _Container = ({ children, isDragging, isSelected, isOpen, hasChildren, hasPresence, isLinkedRef, uid, childrenUids, ...props }) => {
return <Box
className={[
@@ -98,4 +100,4 @@ const _Container = ({ children, isDragging, isSelected, isOpen, hasChildren, has
> {children}</Box >;
}

export const Container = withErrorBoundary(_Container, { fallback: <div>oops</div> });
export const Container = withErrorBoundary(_Container, { fallback: <p>{ERROR_MESSAGE}</p> });