Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chakra fixes #2126

Merged
merged 33 commits into from
Apr 9, 2022
Merged

Chakra fixes #2126

merged 33 commits into from
Apr 9, 2022

Conversation

shanberg
Copy link
Collaborator

@shanberg shanberg commented Apr 9, 2022 •
edited
Loading

Major

  • Adds separate button to page headers for opening page in sidebar, to prevent more complicated event listeners around title blocks
  • Fixes overflow in all-pages view
  • Fixes selection in sidebar
  • Significantly reduces portaling/DOM weight
  • Fixes ability to click the scrollbar to scroll

Minor

  • Adds overflow-y: overlay fallback
  • Improves inline search/slash menus
  • Makes page sizes consistent

shanberg added 30 commits April 4, 2022 18:15
@shanberg
chore: remove console logs
41f107d
@shanberg
fix: remove content area until editing
c3ec4a9
@shanberg
rfct: make sure every menu and popover is lazy
b281dda
@shanberg
rfct: midflight reducing getcaretpos
6a28dcc
@shanberg
perf: only include autocompletes on active block
ee29db5
@shanberg
rfct: functioning block menu
a57e7d5
@shanberg
fix: inline menu closes on click outside
870250b
@shanberg
fix: can click sidebar to scroll
2574d34
@shanberg
rfct: undo class changes to textarea
1e7c2b4
@shanberg
chore: fix lint issues
e880ef5
@shanberg
fix: sidebar items state in db
39f8365
@shanberg
rfct: only one title component
e37150e
@shanberg
feat: separate button for open in sidebar
bf694f1
@shanberg
feat: separate button for open in sidebar
c35c78c
@shanberg
Merge branch 'separate-title-buttons' of https://github.com/shanberg/…
d5cada9 
…athens into separate-title-buttons
@shanberg
fix: pass more tests
49bb181
@shanberg
fix: consistent page widths
a82f418
@shanberg
fix: all pages table wraps and stretches
7463254
@shanberg
improvement: minor touchup for table header
8d4c281
@shanberg
perf: early returns for menus in blocks
38bda25
@shanberg
improvement: ellipsize long shortcuts in sidebar
2cf8996
@shanberg
improvement: minor teaks for accessibility
c223281
@shanberg
perf: use system fonts for speed
e4c26eb
@shanberg
perf: remove unused css
506ff8c
@shanberg
improvement: better css for older browsers
4648c6b
@shanberg
improvement: style improvements to slash menu
12e950f
@shanberg
improvement: esc just closes autocomplete
32a4a82
@shanberg
improvement: dont round textare corner
1f2e692
@shanberg
improvement: autocomplete closer to insertion point
fd91205
@shanberg
chore: minor cleanup
b5d4197
@vercel
Copy link

vercel bot commented Apr 9, 2022 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/athens-research/athens/CN6CSVHebRSBhHu1aacSef2CUMHk
✅ Preview: https://athens-git-fork-shanberg-separate-title-buttons-athens-research.vercel.app

@shanberg shanberg merged commit bf30d85 into athensresearch:chakra-testing Apr 9, 2022
@shanberg shanberg deleted the separate-title-buttons branch April 9, 2022 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@shanberg