Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Polish-toasts #2105

Merged
merged 5 commits into from
Apr 4, 2022
Merged

Polish-toasts #2105

merged 5 commits into from
Apr 4, 2022

Conversation

shanberg
Copy link
Collaborator

@shanberg shanberg commented Apr 4, 2022

  • Toasts react to current color mode instead of being a fixed color
  • Toast 'info' status color uses a better color
  • refactor: fully replace colors object with semantic tokens

@vercel
Copy link

vercel bot commented Apr 4, 2022 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/athens-research/athens/2eSKqX8sUosdiEnaHVkRw62aeNPG
✅ Preview: https://athens-git-fork-shanberg-polish-toasts-athens-research.vercel.app

@shanberg shanberg requested a review from filipesilva April 4, 2022 03:00
@filipesilva filipesilva merged commit 9da959c into athensresearch:main Apr 4, 2022
@filipesilva filipesilva mentioned this pull request Apr 4, 2022
Merged
filipesilva added a commit to filipesilva/athens that referenced this pull request Apr 4, 2022
@filipesilva
Revert "Merge pull request athensresearch#2105 from shanberg/polish-t…
3ecfd56 
…oasts"

This reverts commit 9da959c, reversing
changes made to 11ebd51.
@shanberg shanberg deleted the polish-toasts branch July 1, 2022 02:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@filipesilva filipesilva filipesilva approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shanberg @filipesilva