Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Link Creation Reporting #2100

Merged
merged 5 commits into from
Apr 4, 2022

Conversation

neotyk
Copy link
Collaborator

@neotyk neotyk commented Mar 29, 2022

No description provided.

@vercel
Copy link

vercel bot commented Mar 29, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/athens-research/athens/7u4iy9F4JscWjwAQdgJ4E6XFniE8
✅ Preview: https://athens-git-fork-neotyk-feat-link-creatio-9823c9-athens-research.vercel.app

@neotyk neotyk marked this pull request as ready for review March 30, 2022 08:23
Calculates removed and added links
(page links & block refs).
Hook re-frame events to structural diffs and activate reporting.
@tangjeff0
Copy link
Collaborator

Seems good, but didn't look as closely at structural parser. We should do Eng Testing before release to make sure linking still works for in-memory db and is reported in posthog @neotyk

@tangjeff0 tangjeff0 requested a review from filipesilva March 31, 2022 08:42
Copy link
Collaborator

@filipesilva filipesilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only comment that I really want addressed is the one about the missing uid.

@neotyk neotyk merged commit 4dc0b51 into athensresearch:main Apr 4, 2022
@neotyk neotyk deleted the feat/link-creation-reporting branch April 4, 2022 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants