Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

event log filter #2098

Merged
merged 15 commits into from
Apr 5, 2022
Merged

event log filter #2098

merged 15 commits into from
Apr 5, 2022

Conversation

filipesilva
Copy link
Collaborator

  • feat: support event log migrations
  • build: update to clojure 11
  • rfct: move migrator into own ns
  • fix: current version is 0 if none is present
  • feat: migrate events without a uid
  • fix: fix args on migrate call site
  • rfct: add athens.self-hosted.fluree.utils
  • fix: get-current-version should return 0 on err
  • feat: migrate to efficient event log filtering

@vercel
Copy link

vercel bot commented Mar 28, 2022 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/athens-research/athens/74cWcSVgHuomBchMa2TW5LTDQ83n
✅ Preview: https://athens-git-fork-filipesilva-event-log-filter-athens-research.vercel.app

@filipesilva filipesilva marked this pull request as draft March 28, 2022 22:15
@filipesilva
Copy link
Collaborator Author

Tests hang forever both locally and on CI after adding the fluree tests. Opened an issue with repro at fluree/db#163.

filipesilva
filipesilva commented Mar 30, 2022
View reviewed changes
deps.edn
@@ -1,7 +1,7 @@
{:paths ["src/clj" "src/cljs" "src/cljc" "src/js" "src/gen" "test"]

:deps
{org.clojure/clojure #:mvn{:version "1.10.3"}
{org.clojure/clojure #:mvn{:version "1.11.0"}
org.clojure/clojurescript #:mvn{:version "1.10.879"}
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NB: clojurescript is not updated to 11 yet, that requires changing the version here and also a shadow-cljs version that supports it (iirc shadow-cljs overwrites it).

@filipesilva filipesilva requested a review from neotyk March 31, 2022 08:32
@filipesilva filipesilva marked this pull request as ready for review March 31, 2022 08:33
neotyk
neotyk approved these changes Apr 5, 2022
View reviewed changes
Copy link
Collaborator

@neotyk neotyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Tried shutting down JVM after tests, with little luck, Fluree is leaving a lot concurrent stuff behind.

src/clj/athens/self_hosted/event_log.clj Outdated Show resolved Hide resolved
src/clj/athens/self_hosted/event_log.clj
:event/data (pr-str data)
;; Compute the new order number as 1 higher than last.
;; This will be 1 if there are no events yet.
;; NOTE: is max-pred-val efficient for very large collections? I don't know.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is this fluree magic?
It loos like a inline fn, but it's a string.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is a smart function, used in a transaction: https://developers.flur.ee/docs/guides/advanced/smart-functions/10/

@filipesilva filipesilva merged commit 7b738d2 into athensresearch:main Apr 5, 2022
filipesilva added a commit to filipesilva/athens that referenced this pull request Apr 6, 2022
@filipesilva
Revert "Merge pull request athensresearch#2098 from filipesilva/event…
a865c87 
…-log-filter"

This reverts commit 7b738d2, reversing
changes made to 5a9507f.
@filipesilva filipesilva mentioned this pull request Apr 6, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neotyk neotyk neotyk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@filipesilva @neotyk