Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Page/Block Creation Reporting #2090

Merged
merged 14 commits into from
Mar 30, 2022

Conversation

neotyk
Copy link
Collaborator

@neotyk neotyk commented Mar 21, 2022

Source:

  • paste internal
  • Undo & Redo
  • :block/save re-frame event
  • :enter/split-block re-frame event
  • :enter/new-block
  • :enter/add-child
  • :enter/bump-up
  • :enter/open-block-add-child
  • :block/link
  • events :page/new
  • :backspace/delete-merge-block-with-save
  • :backspace/delete-merge-block
  • :enter/split-block
  • :block/save
  • :indent
  • :unindent
  • :paste-verbatim
  • :unlinked-references/link
  • :unlinked-references/link-all
  • :block/save undo
  • :page/merge undo

Source: paste internal
@neotyk neotyk requested a review from tangjeff0 March 21, 2022 17:23
@vercel
Copy link

vercel bot commented Mar 21, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/athens-research/athens/E23RbCKD1rCQJX9NbyKLoWse515P
✅ Preview: https://athens-git-fork-neotyk-feat-feat-mon-cre-6fa92d-athens-research.vercel.app

source: `:block/save`
sources:
* [x] :enter/new-block
* [x] :enter/add-child
* [x] :enter/bump-up
* [x] :enter/open-block-add-child
* [x] :block/link
source: `:block/save` re-frame event
source: `:indent` re-frame event
source: `:unindent` re-frame event.
source: `:paste-verbatim` re-frame event.
@neotyk neotyk marked this pull request as ready for review March 28, 2022 13:13
{:fx [[:dispatch [:resolve-transact-forward event]]]}))))
{:fx [[:dispatch-n (cond-> [[:resolve-transact-forward event]]
(seq new-titles)
(conj [:reporting/page.create {:source (or source :unknown-block-save)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀 :unknown-block-save

@neotyk neotyk merged commit 98b6e2b into athensresearch:main Mar 30, 2022
@neotyk neotyk deleted the feat/feat-mon-creation-linking branch March 30, 2022 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants