Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: set a 1MB event limit #2062

Merged
merged 8 commits into from
Apr 5, 2022

Conversation

filipesilva
Copy link
Collaborator

No description provided.

@vercel
Copy link

vercel bot commented Mar 3, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/athens-research/athens/ktr2q4jeSewHwJtXihJVUbMzN2qB
✅ Preview: https://athens-git-fork-filipesilva-event-size-limit-athens-research.vercel.app

@filipesilva
Copy link
Collaborator Author

@sid597 would like your help testing the limit, since you already have test code.

@neotyk do you think this is a reasonable way of adding the limit check, or do you have a better idea?

@filipesilva
Copy link
Collaborator Author

Realized this later on: this limit also applies to db dump will cause our team server to stop working. We can just exclude db dump from the limit, but the question of what limit there is for db dump still remains.

@filipesilva filipesilva marked this pull request as ready for review March 14, 2022 16:58
@filipesilva
Copy link
Collaborator Author

I will need to test we don't have any 1mb event before merging by replaying the team log.

@neotyk
Copy link
Collaborator

neotyk commented Apr 5, 2022

When testing, I can't even paste 80KB of text into the app.
Not sure if this is new.

@neotyk
Copy link
Collaborator

neotyk commented Apr 5, 2022

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants