Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make block merge delete work on Atomic Ops #1734

Merged

Conversation

neotyk
Copy link
Collaborator

@neotyk neotyk commented Oct 14, 2021

No description provided.

@vercel
Copy link

vercel bot commented Oct 14, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/athens-research/athens/2hEWFhqzbKn8XvC6m3PhD3sA1ZnK
✅ Preview: https://athens-git-fork-neotyk-dev-fix-block-mer-c2c858-athens-research.vercel.app

@neotyk neotyk added the r/rtc Issues to be resolved as part of the RTC release. label Oct 14, 2021
@neotyk neotyk self-assigned this Oct 14, 2021
Still need to write tests for removing parent.
@neotyk neotyk marked this pull request as ready for review October 18, 2021 16:17
Copy link
Collaborator

@filipesilva filipesilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice tests and recursive retract logic

@filipesilva filipesilva merged commit a419876 into athensresearch:feature/rtc-v1 Oct 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
r/rtc Issues to be resolved as part of the RTC release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants