Fixed regex patterns for block embed and block ref

[sid597]

@neotyk @filipesilva How do I do this is a better way ?

[vercel]

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/athens-research/athens/9eD5eApXaX1gzmP6CKYERd7SYmSg
✅ Preview: https://athens-git-fork-sid597-copy-paste-patterns-fix-athens-research.vercel.app

[filipesilva]

I am afraid of this. I think once enough string regex concats are committed into a codebase a portal to hell will appear as a symlink in a toplevel dir. Prior art indicates this is an undesirable situation.

I don't know how to get out of this problem right now. Maybe something like https://github.com/lambdaisland/regal or https://github.com/ztellman/automat would let us slow the descent into madness by providing a higher level language.

[filipesilva]

Hm I think I merged this to quickly, and left a carve error because I didn't understand what was happening. Following up on the rtc branch.

[filipesilva]

@sid597 I ended up reverting the changes on rtc, because as far as I could tell they didn't do anything.

I tried adding these tests in athens.patterns-test:

(deftest block-pattern
  (are [x y] (= (re-find patterns/block-pattern x) y)
    "an ((uid))" "((uid))"
    "not (uid)" nil
    "two ((uid1)) ((uid2))" "((uid1))"))


(deftest block-embed-pattern
  (are [x y] (= (re-find patterns/block-embed-pattern x) y)
    "an {{[[embed]]: ((uid))}}" "{{[[embed]]: ((uid))}}"
    "not {{[[embed]]: abc}}" nil))


(deftest block-refs-pattern
  (are [x y] (= (re-find patterns/block-refs-pattern x) y)
    "an {{[[embed]]: ((uid))}}" "{{[[embed]]: ((uid))}}"
    "an ((uid))" "((uid))"))

The tests passed before and after your changes. Can make some tests for what's supposed to change here, and open a new PR with those changes?