-
-
Notifications
You must be signed in to change notification settings - Fork 401
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Page-level presence #1653
Page-level presence #1653
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/athens-research/athens/8svBxySYWGA99AWY1EyKrC7xjULh |
417801d
to
ee20473
Compare
ce23f50
to
26d3259
Compare
LGTM |
Not sure if this is a known issue. I'm guessing this can be addressed in a future PR. |
@tangjeff0 it's known, some of the in-concept elements (like blocks) have erros like this on storybook. Avatar is being used right now but that particular story uses blocks as well. IIRC @shanberg was going to fix those comps that error on storybook. |
Great work @filipesilva @shanberg ! |
Can you provide some context on why Babel was imported in this PR? Just curious @filipesilva |
@tangjeff0 we were already using babel, but with a different config (.babelrc instead of babel.config.js). Trying to use to use the more complex presence components revealed issues with the babel setup that required a change in config type (to add functions) and change in configuration items (to fix the issues proper). For futher context, storybook itself also uses babel for TS compilation, and shadow-cljs uses babel for node_modules compilation from ESM to CJS. |
I do plan to fix, just lower priority. |
No description provided.