Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Page-level presence #1653

Merged

Conversation

filipesilva
Copy link
Collaborator

No description provided.

@vercel
Copy link

vercel bot commented Sep 15, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/athens-research/athens/8svBxySYWGA99AWY1EyKrC7xjULh
✅ Preview: https://athens-git-fork-filipesilva-presence-details-athens-research.vercel.app

@filipesilva filipesilva changed the title build: fix import semantics for components Page-level presence Sep 15, 2021
@filipesilva filipesilva marked this pull request as ready for review September 16, 2021 11:17
@neotyk neotyk requested review from neotyk and removed request for neotyk September 16, 2021 12:22
@neotyk
Copy link
Collaborator

neotyk commented Sep 16, 2021

LGTM

@tangjeff0
Copy link
Collaborator

tangjeff0 commented Sep 16, 2021

Not sure if this is a known issue. I'm guessing this can be addressed in a future PR.

image

@filipesilva
Copy link
Collaborator Author

@tangjeff0 it's known, some of the in-concept elements (like blocks) have erros like this on storybook. Avatar is being used right now but that particular story uses blocks as well. IIRC @shanberg was going to fix those comps that error on storybook.

@filipesilva filipesilva merged commit 107befb into athensresearch:feature/rtc-v1 Sep 16, 2021
@tangjeff0
Copy link
Collaborator

Great work @filipesilva @shanberg !

@tangjeff0
Copy link
Collaborator

Can you provide some context on why Babel was imported in this PR? Just curious @filipesilva

@filipesilva
Copy link
Collaborator Author

@tangjeff0 we were already using babel, but with a different config (.babelrc instead of babel.config.js). Trying to use to use the more complex presence components revealed issues with the babel setup that required a change in config type (to add functions) and change in configuration items (to fix the issues proper).

For futher context, storybook itself also uses babel for TS compilation, and shadow-cljs uses babel for node_modules compilation from ESM to CJS.

@shanberg
Copy link
Collaborator

shanberg commented Sep 16, 2021

Not sure if this is a known issue. I'm guessing this can be addressed in a future PR.

I do plan to fix, just lower priority.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants