Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mapshaper v0.4.x #73

Merged
merged 75 commits into from
Mar 27, 2018
Merged

Mapshaper v0.4.x #73

merged 75 commits into from
Mar 27, 2018

Conversation

ateucher
Copy link
Owner

Closes #60, closes #61, closes #63, closes #67, closes #70, closes #71

ateucher added 30 commits October 27, 2017 16:40
@ateucher
Update mapshaper lib
74a3ea2
@ateucher
Parse raw return to char
3ccdaf0
@ateucher
Use this instead of $ for -each command
6927822
@ateucher
Make a function to construct js callback function
023428d
@ateucher
Use new method for combining objects into one for applyCommands in ma…
53b9bad 
…pshaper v0.4.x
@ateucher
line RANK is numeric, TYPE is character
a1a833e
@ateucher
Start on using system mapshaper
9ecc542
@ateucher
Check for system mapshaper; better tempfile handling
66aa7e3
@ateucher
sys argument in ms_lines
428c5b9
@ateucher
Make output geojson, not buffer, as bonks on V8 mapshaper
5222e2e
@ateucher
Comment out buffer processing - not used currently but if set output …
6b6aedc 
…to buffer it is used
@ateucher
system: io to/from tempfiles using sf/sp funs
e0b6d20
@ateucher
Add sys argument to ms_lines methods
aa6912d
@ateucher
Default file = FALSE for sf/sp_to_GeoJSON
e60508e
@ateucher
Merge branch 'master' into mapshaper_v0.4.x
3e2b50a
@ateucher
Default sys - FALSE for ms_sp
4f6ff20
@ateucher
Comment out testing character strings in ms_clip_erase. #63
5f1b4c2
@ateucher
Comment out testing character strings in ms_dissolve, fix other faili…
d09ba19 
…ng test. #63
@ateucher
Remove whitespace in geojson strings in test_null_geometries. #63
8a6d508
@ateucher
Remove whitespace in geojson strings in test-explode. #63
e33e4aa
@ateucher
Don't directly test character strings in filter_islands and filter_fi…
3a3e36c 
…elds. #63
@ateucher
Remove direct string comparison tests on innerlines, lines, and points.
c9b53b0 
#63
@ateucher
Adjust ms_lines tests to deal with RANK field generated by newer -lin…
cd57251 
…es command
@ateucher
stringsAsFactors = FALSE when converting json to expected_sp in test-…
1637b8a 
…lines
@ateucher
Clean ws in character strings for simplify tests
2b4fda5
@ateucher
Implement sys for dissolve; update docs
c62cdd6
@ateucher
Add readr to Imports, update dep versions
9e2302a
@ateucher
Only check character columns for curly brace missing values.
0ec197d 
Also don't remove additional classes (just sf)
@ateucher
Merge branch 'master' into mapshaper_v0.4.x
6b38985 
# Conflicts:
#	R/utils.R
@ateucher
Use vapply with inherits for safety
9c3edb3
ateucher added 22 commits March 26, 2018 14:40
@ateucher
Finish tests for sys
8d1aa12
@ateucher
Preserve name of geometry column for sf methods. Fixes #70
3d5cf2e
@ateucher
Update mapshaper to v0.4.64
d1cf561
@ateucher
Update NEWS, bump version
cd8d449
@ateucher
Export check_sys_mapshaper, allow printing a message that states version
d96abee
@ateucher
Update README and vignette
26b20a2
@ateucher
Document
0bf727f
@ateucher
update revdep_checks
5c23d70
@ateucher
specify devtools install on Travis
9583d1b
@ateucher
tidy DESCRPITION, document with markdown enabled
c3d6024
@ateucher
minify mapshaper js file
477ef00
@ateucher
Clean up tests
0b02b79
@ateucher
Finish tests for system mapshaper
01621dc
@ateucher
Require geojsonio > 0.6
1f3ec56
@ateucher
put geojsonio in remotes for dev version
1aea983
@ateucher
Remove Date field from DESCRIPTION
25116ea
@ateucher
Try unminified js (appveyor)
de56f50
@ateucher
try minified js again (appveyor)
7e31893
@ateucher
Try to ie-proof minified js
228eaf8
@ateucher
Try uglify-js with ascii_only=true
02b8967
@ateucher
Update isnt/mapshaper/README.md
9d3ea47
@ateucher
newlines
c1c3146
@codecov
Copy link

codecov bot commented Mar 27, 2018 •
edited
Loading

Codecov Report

Merging #73 into master will decrease coverage by 1.47%.
The diff coverage is 95.69%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #73      +/-   ##
==========================================
- Coverage   96.76%   95.29%   -1.48%     
==========================================
  Files          11       11              
  Lines         587      616      +29     
==========================================
+ Hits          568      587      +19     
- Misses         19       29      +10
Impacted Files Coverage Δ
R/clip_erase.R 97.98% <100%> (-0.28%) ⬇️
R/simplify.R 96.96% <100%> (-0.05%) ⬇️
R/drop_null_geometries.R 100% <100%> (ø) ⬆️
R/filter_fields.R 100% <100%> (ø) ⬆️
R/lines.R 94.87% <100%> (+0.42%) ⬆️
R/filter_islands.R 100% <100%> (ø) ⬆️
R/inner_lines.R 100% <100%> (ø) ⬆️
R/dissolve.R 92.06% <100%> (ø) ⬆️
R/explode.R 100% <100%> (ø) ⬆️
R/points.R 100% <100%> (ø) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9342c88...b1fda71. Read the comment docs.

@ateucher ateucher merged commit 8687680 into master Mar 27, 2018
@ateucher ateucher deleted the mapshaper_v0.4.x branch March 27, 2018 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@ateucher