feat: new community section from community branch #917

akshatnema · 2022-08-25T15:03:04Z

Description
This PR adds a new page to the website which describes all the community-related information and announcements in it. This PR is made draft to track the changes done in the community branch. Whoever wants to contribute to this issue/PR has to make a branch from community branch to his forked repo.

Related issue(s)
Resolves #903

netlify · 2022-08-25T15:03:10Z

✅ Deploy Preview for asyncapi-website ready!

Name	Link
🔨 Latest commit	`4c43126`
🔍 Latest deploy log	https://app.netlify.com/sites/asyncapi-website/deploys/64253cd23e19a70008b46046
😎 Deploy Preview	https://deploy-preview-917--asyncapi-website.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

akshatnema · 2022-08-25T15:23:19Z

@AceTheCreator, the PR for community section is initiated again and you can now track the changes made in the branch, with respect to the master branch.

Regarding resolving the conflicts, I would tag @magicmatatjahu @derberg for this. Which method we should use, directly make a merge commit to the communtiy branch or we should initialize a PR for this to track what changes are made during the merge command in the branch?

derberg · 2022-08-29T12:56:24Z

any is good, really, it is merged into feature branch anyway, so if something is broken with solving conflicts, it can also be fixed as a followup.

I say, if easier for you is to do it directly to community branch, then do it. @magicmatatjahu ?

AceTheCreator · 2022-08-29T13:41:48Z

@derberg what happened to the previous PR that got merged into the community branch?

derberg · 2022-08-29T13:43:58Z

what happened to the previous PR that got merged into the community branch?

@AceTheCreator it got merged as you noticed 😄 #902

Signed-off-by: akshatnema <20bcs022@iiitdmj.ac.in>

Co-authored-by: Khuda Dad Nomani <32505158+KhudaDad414@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Anisat Akinbani <52763841+Annysah@users.noreply.github.com> Co-authored-by: Anurag Goswami <64116092+Anurag607@users.noreply.github.com> Co-authored-by: V Thulisile Sibanda <66913810+thulieblack@users.noreply.github.com> Co-authored-by: Alejandra Quetzalli <alejandra.olvera.novack@gmail.com> Co-authored-by: Amisha Kumari <amishakumari544@gmail.com> Co-authored-by: asyncapi-bot <bot+chan@asyncapi.io> Co-authored-by: Christophe Dujarric <christophe@bump.sh> Co-authored-by: Martin F <gabel@users.noreply.github.com> Co-authored-by: Nelson <iamnelsonmichael@gmail.com> Co-authored-by: Lukasz Gornicki <lpgornicki@gmail.com>

Signed-off-by: akshatnema <20bcs022@iiitdmj.ac.in>

Co-authored-by: Khuda Dad Nomani <32505158+KhudaDad414@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Anisat Akinbani <52763841+Annysah@users.noreply.github.com> Co-authored-by: Anurag Goswami <64116092+Anurag607@users.noreply.github.com> Co-authored-by: V Thulisile Sibanda <66913810+thulieblack@users.noreply.github.com> Co-authored-by: Alejandra Quetzalli <alejandra.olvera.novack@gmail.com> Co-authored-by: Amisha Kumari <amishakumari544@gmail.com> Co-authored-by: asyncapi-bot <bot+chan@asyncapi.io> Co-authored-by: Christophe Dujarric <christophe@bump.sh> Co-authored-by: Martin F <gabel@users.noreply.github.com> Co-authored-by: Nelson <iamnelsonmichael@gmail.com> Co-authored-by: Lukasz Gornicki <lpgornicki@gmail.com>

Signed-off-by: akshatnema <20bcs022@iiitdmj.ac.in>

derberg · 2023-03-01T12:45:23Z

the thing is that when you go to /community, to a kinda Community Landing Page, you see it promotes:

discussions
ambassadors
meetings
slack
goals and upcoming work

but when you look at:

there are some additional community items that are not promoted on landing page

so in short I think the idea behind /community view should be to highlight all the items that people can find there.

makes sense? not a must-have for me in this PR but if we have an agreement we should definitely have a dedicated followup issue on that

AceTheCreator · 2023-03-01T13:50:59Z

the thing is that when you go to /community, to a kinda Community Landing Page, you see it promotes:

discussions

ambassadors

meetings

slack

goals and upcoming work

but when you look at:

there are some additional community items that are not promoted on landing page

so in short I think the idea behind /community view should be to highlight all the items that people can find there.

makes sense? not a must-have for me in this PR but if we have an agreement we should definitely have a dedicated followup issue on that

I understand now. But i thought keeping the landing page simple and straightforward was a really good approach.

I can create a separate issue and make someone contribute to it :)

What do you think @alequetzalli?

quetzalliwrites · 2023-03-02T03:47:21Z

I understand now. But i thought keeping the landing page simple and straightforward was a really good approach.
I can create a separate issue and make someone contribute to it :)

What do you think @alequetzalli?

Uh oh... do I have to answer this one? 😄 Can't I just agree with everyone? 😂😂😂😂 LOL kidding...

Ok, so tbh here's my take:

I agree with @derberg on his concern over the Community item's behavior in the nav bar; I too would expect to be allowed to click on it and have it take me directly to the landing page.
I happen to feel that the current Community landing page feels too marketing-like. IOW... full of pretty colors and graphics, but not necessarily have the information I need as a community member. I also think that Lukasz makes a good point about that page currently missing the most context of what community members will look for there... my vote is to fix that page because it currently does not serve the community as well as it could. ♥️

akshatnema

Hey @AceTheCreator, here's my review...

I see that lot of images are being added via this PR and they are in various formats like PNG, JPEG or JPG. Kindly make these images compressed (if possible) and in the format of either SVG or WEBP. You can use https://squoosh.app/ to convert the images.

Also, I see 2 images of Fran being added, both are same, just different in terms of format of the images. Kindly have only 1 image of each person.

akshatnema · 2023-03-04T08:20:00Z

components/layout/CommunityLayout.js

+import React from 'react';
+import Head from '../Head';
+import Container from './Container';
+import NavBar from '../navigation/NavBar';
+import StickyNavbar from '../navigation/StickyNavbar';
+
+
+export default function CommunityLayout({
+  title,
+  description,
+  children,
+  wide = true,
+}) {
+  return (
+    <>
+      <Head title={title} description={description} />
+      <StickyNavbar>
+        <NavBar className="max-w-screen-xl block px-4 sm:px-6 lg:px-8 mx-auto" />
+      </StickyNavbar>
+      <Container wide={wide}>{children}</Container>
+    </>
+  );
+}


Suggested change

import React from 'react';

import Head from '../Head';

import Container from './Container';

import NavBar from '../navigation/NavBar';

import StickyNavbar from '../navigation/StickyNavbar';

export default function CommunityLayout({

title,

description,

children,

wide = true,

}) {

return (

<>

<Head title={title} description={description} />

<StickyNavbar>

<NavBar className="max-w-screen-xl block px-4 sm:px-6 lg:px-8 mx-auto" />

</StickyNavbar>

<Container wide={wide}>{children}</Container>

</>

);

}

This file has been created but not used anywhere in the repo and it already has the same changes as in GenericLayout. Kindly remove this file as it is not needed.

akshatnema · 2023-03-04T08:24:23Z

pages/community/ambassadors/index.js

+const data = [
+  {
+    title: 'Written content',
+    details:
+      'Write guides, step-by-step tutorials, community documentation, AsyncAPI blog posts, and beyond.',
+    icon: '/img/illustrations/blog.svg',
+  },
+  {
+    title: 'Video content',
+    details:
+      'Produce educational videos on YouTube and other platforms for AsyncAPI.',
+    icon: '/img/illustrations/video-creation.svg',
+  },
+  {
+    title: 'Live streams',
+    details: 'Moderate or host live streams that demo the AsyncAPI ecosystem.',
+    icon: '/img/illustrations/live.svg',
+  },
+  {
+    title: 'Give talks',
+    details:
+      'Speak at meetups and conferences; we’ll help with slides, abstract submissions, and travel budget.',
+    icon: '/img/illustrations/speaking.svg',
+  },
+  {
+    title: 'Interactive Learning',
+    details:
+      'Gamify educational content and create interactive learning paths for teaching AsycnAPI and event-driven architectures.',
+    icon: '/img/illustrations/learning-app.svg',
+  },
+  {
+    title: 'Build real-life usecases example',
+    details:
+      'Develop real-life usecase project example using the AsyncaAPI specification',
+    icon: '/img/illustrations/codes.svg',
+  },
+  {
+    title: 'AsyncAPI Contributions',
+    details:
+      'Collaborate with the AsyncAPI community via diverse contributions and improvements.',
+    icon: '/img/illustrations/advisor.svg',
+  },
+  {
+    title: 'Gather Use-Cases',
+    details:
+      'Collect data from existing AsyncAPI users and create use-case studies.',
+    icon: '/img/illustrations/meeting.jpg',
+  },
+];
+
+
+const tokens = [
+  {
+    emoji: '🗺️',
+    title: 'Travel',
+    details: 'Ambassadors are provided free entry to AsyncAPI conferences.',
+  },
+  {
+    emoji: '🌟',
+    title: 'Recognition',
+    details: 'Ambassadors receive community-wide recognition.',
+  },
+  {
+    emoji: '🎁',
+    title: 'Special Swags',
+    details:
+      'Community members recognize you by gifting you exclusive AsyncAPI Ambassador swag.',
+  },
+  {
+    emoji: '🧰',
+    title: 'Workshop Swags',
+    details:
+      'Ambassadors are gifted swag from AsyncAPI conferences and workshops.',
+  },
+];


Can we include this array of data inside another json file as we are getting huge chunks of lines inside this file and later on, it will be difficult for us to extend the page further?

akshatnema · 2023-03-04T08:38:15Z

pages/community/index.js

+        />
+      </div>
+    </div>
+  );


I see that you are making a separate variable to render this block. Will you think of making this as a separate component?

Also, I see that most of the files inside pages/communtiy has huge lines of code. Can we think of making separate components for them as we are also looking for making UI tests on website?

* replaced image format * removed unused component * moved ambassadors content to a new file * created components for community section * changes implemented * . * added shadow to cards and bd color * added suggested changes * .

AceTheCreator · 2023-03-16T13:41:44Z

Any other suggestions? cc @derberg @akshatnema @alequetzalli

derberg · 2023-03-16T15:17:22Z

@AceTheCreator can you fix merge conflicts first 🙏🏼

AceTheCreator · 2023-03-16T15:18:46Z

@AceTheCreator can you fix merge conflicts first 🙏🏼

@akshatnema your help is needed :)

Signed-off-by: akshatnema <20bcs022@iiitdmj.ac.in>

akshatnema

It's not possible for me to review this PR as a whole from the codebase point of view as there are around 2k lines of changes. So, we will make sure we won't be dealing with any such PR in the future and will review each individual PR despite having the thoughts that we can improve it later.

Here's my another round of review:

The videos in the list are not sorted according to the ascending order of dates, like the meeting of 20th March should be displayed first and then further meetings should be displayed according to the dates.

akshatnema · 2023-03-18T10:31:48Z

components/navigation/communityItems.js

  { icon: IconDashboard, title: 'Dashboard',href: '/community/dashboard', description: `Just need a good first issue to start your contribution journey? or want to see what topics are hot in discussion?`},
-  { icon: IconMeetings, title: 'Meetings', href: '/community/meetings', description: 'See what meetings are organized under AsyncAPI umbrella and join one of them.' },
+  { icon: IconMeetings, title: 'Meetings', href: '/community/events', description: 'See what meetings are organized under AsyncAPI umbrella and join one of them.' },


Should the titile for this option be changed to something else for this page now, as we are not only restricted to Meetings but rather we are more focused on the events too like AsyncAPI Conference?
WDYT @derberg @alequetzalli

It's best if we rename the title to "Events"

AceTheCreator · 2023-03-20T10:56:25Z

The videos in the list are not sorted according to the ascending order of dates, like the meeting of 20th March should be displayed first and then further meetings should be displayed according to the dates.

@akshatnema you're right akshat

AceTheCreator · 2023-03-20T11:25:25Z

It's not possible for me to review this PR as a whole from the codebase point of view as there are around 2k lines of changes. So, we will make sure we won't be dealing with any such PR in the future and will review each individual PR despite having the thoughts that we can improve it later.

@akshatnema I disagree with this approach, as it only prolongs this PR. So I'll advise you to create the review once, and whatever thing you find out later on can be opened as a GFI. Your approach will only keep making me open more PR fixing small changes

akshatnema · 2023-03-26T15:06:15Z

@akshatnema I disagree with this approach, as it only prolongs this PR. So I'll advise you to create the review once, and whatever thing you find out later on can be opened as a GFI. Your approach will only keep making me open more PR fixing small changes

Sorry, but actually you misunderstood my concern slightly. I'm not asking to make new PRs to make small changes in this PR. But what I said that when you had initialized individual PRs for the pages of the community section previously, I must have made a complete review for that PR instead of waiting for them to merge in the community branch. Anyways, my reviews are done. Approved ✔️. Waiting for the approval from @derberg @alequetzalli

derberg

@alequetzalli we need your final approval

AceTheCreator · 2023-03-28T21:15:23Z

@alequetzalli, any other suggestion from your end? Before we go ahead merge this PR

akshatnema · 2023-03-29T18:29:05Z

@AceTheCreator Will you like to merge the PR? Since, you are the major contributor of this PR and I want you to take this pleasure. Just do the / rtm command in this PR 😄

AceTheCreator · 2023-03-30T08:10:12Z

/rtm

feat: new community section (#902)

736336a

akshatnema and others added 21 commits August 31, 2022 22:41

Merge branch 'master' into community

e6767e5

Signed-off-by: akshatnema <20bcs022@iiitdmj.ac.in>

Merge branch 'master' into community

8c756a5

Merge branch 'master' into community

1c0cdec

Merge branch 'master' into community

217ad55

Merge branch 'master' into community

a39d753

Merge branch 'master' into community

4584302

Merge branch 'master' into community

9494848

Signed-off-by: akshatnema <20bcs022@iiitdmj.ac.in>

Merge branch 'master' into community

bca7c9b

Signed-off-by: akshatnema <20bcs022@iiitdmj.ac.in>

feat: community landing page (#1119)

fa3e9fa

Merge branch 'master' into community

c693da4

Merge branch 'master' into community

aba4300

Merge branch 'master' into community

f50fb2d

Signed-off-by: akshatnema <20bcs022@iiitdmj.ac.in>

Merge branch 'master' into community

c4d57fc

Merge branch 'master' into community

3ff0a93

Merge branch 'master' into community

e98a4c0

resolved communityItems with master

0888bec

Signed-off-by: akshatnema <20bcs022@iiitdmj.ac.in>

Merge branch 'master' into community

5863133

Merge branch 'master' into community

b22c957

corrected ambassadors file

691bc77

Signed-off-by: akshatnema <20bcs022@iiitdmj.ac.in>

akshatnema marked this pull request as ready for review February 8, 2023 18:21

akshatnema requested review from quetzalliwrites and asyncapi-bot-eve as code owners February 8, 2023 18:21

fix: minor enhancements (#1380)

be5a92b

akshatnema commented Mar 4, 2023

View reviewed changes

Merge branch 'master' into community

0c6eac0

AceTheCreator mentioned this pull request Mar 6, 2023

fix: more enhancement to UI #1402

Merged

fix: more enhancement to UI (#1402)

f0e7afb

* replaced image format * removed unused component * moved ambassadors content to a new file * created components for community section * changes implemented * . * added shadow to cards and bd color * added suggested changes * .

Merge branch 'master' into community

093e4d0

Signed-off-by: akshatnema <20bcs022@iiitdmj.ac.in>

akshatnema commented Mar 18, 2023

View reviewed changes

AceTheCreator mentioned this pull request Mar 20, 2023

fix: event page update #1449

Merged

fix: event page update (#1449)

f1b6515

akshatnema and others added 2 commits March 26, 2023 20:36

Merge branch 'master' into community

8d725d9

Merge branch 'master' into community

19d29b0

derberg approved these changes Mar 28, 2023

View reviewed changes

derberg mentioned this pull request Mar 28, 2023

chore(blog): march summary blog post #1463

Merged

quetzalliwrites approved these changes Mar 29, 2023

View reviewed changes

Merge branch 'master' into community

4c43126

asyncapi-bot added the ready-to-merge label Mar 30, 2023

asyncapi-bot merged commit 57d4312 into master Mar 30, 2023

derberg deleted the community branch April 13, 2023 13:46

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: new community section from community branch #917

feat: new community section from community branch #917

akshatnema commented Aug 25, 2022

netlify bot commented Aug 25, 2022 •

edited

Loading

akshatnema commented Aug 25, 2022

derberg commented Aug 29, 2022

AceTheCreator commented Aug 29, 2022

derberg commented Aug 29, 2022

derberg commented Mar 1, 2023

AceTheCreator commented Mar 1, 2023

quetzalliwrites commented Mar 2, 2023

akshatnema left a comment

akshatnema Mar 4, 2023

akshatnema Mar 4, 2023

akshatnema Mar 4, 2023 •

edited

Loading

AceTheCreator commented Mar 16, 2023

derberg commented Mar 16, 2023

AceTheCreator commented Mar 16, 2023

akshatnema left a comment

akshatnema Mar 18, 2023

AceTheCreator Mar 20, 2023

AceTheCreator commented Mar 20, 2023 •

edited

Loading

AceTheCreator commented Mar 20, 2023

akshatnema commented Mar 26, 2023 •

edited

Loading

derberg left a comment

AceTheCreator commented Mar 28, 2023

akshatnema commented Mar 29, 2023

AceTheCreator commented Mar 30, 2023

feat: new community section from community branch #917

feat: new community section from community branch #917

Conversation

akshatnema commented Aug 25, 2022

netlify bot commented Aug 25, 2022 • edited Loading

✅ Deploy Preview for asyncapi-website ready!

akshatnema commented Aug 25, 2022

derberg commented Aug 29, 2022

AceTheCreator commented Aug 29, 2022

derberg commented Aug 29, 2022

derberg commented Mar 1, 2023

AceTheCreator commented Mar 1, 2023

quetzalliwrites commented Mar 2, 2023

akshatnema left a comment

Choose a reason for hiding this comment

akshatnema Mar 4, 2023

Choose a reason for hiding this comment

akshatnema Mar 4, 2023

Choose a reason for hiding this comment

akshatnema Mar 4, 2023 • edited Loading

Choose a reason for hiding this comment

AceTheCreator commented Mar 16, 2023

derberg commented Mar 16, 2023

AceTheCreator commented Mar 16, 2023

akshatnema left a comment

Choose a reason for hiding this comment

akshatnema Mar 18, 2023

Choose a reason for hiding this comment

AceTheCreator Mar 20, 2023

Choose a reason for hiding this comment

AceTheCreator commented Mar 20, 2023 • edited Loading

AceTheCreator commented Mar 20, 2023

akshatnema commented Mar 26, 2023 • edited Loading

derberg left a comment

Choose a reason for hiding this comment

AceTheCreator commented Mar 28, 2023

akshatnema commented Mar 29, 2023

AceTheCreator commented Mar 30, 2023

netlify bot commented Aug 25, 2022 •

edited

Loading

akshatnema Mar 4, 2023 •

edited

Loading

AceTheCreator commented Mar 20, 2023 •

edited

Loading

akshatnema commented Mar 26, 2023 •

edited

Loading