feat: add new newsletter view #644
Conversation
✅ Deploy Preview for asyncapi-website ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
|
Ok for me, but I think we should change the design of this page because we are using the same colors for newsletter as is on the home page. @mcturco Could you check https://deploy-preview-644--asyncapi-website.netlify.app/newsletter and suggest changes, or should we leave it as it is? |
|
Hmm yeah I agree with @magicmatatjahu here. I know the idea was to be a quick solution, but it looks a little bit too "copy and paste" for me, especially because there are no other sections on this new page to break up the dark background. Instead, I would suggest that we remove the dark background (keep it white), change the |
|
event though #designismypassion this time I will agree with you 😆
who said it wasn't 🤣 I literally had to google what Let me know what you think. When I did some tests on my different screens, tbh, I can also remove the footer entirely, I think we can agree that on such a specific view, we do not need it 😄 |
|
@derberg I fixed for you the footer 😘 https://deploy-preview-644--asyncapi-website.netlify.app/newsletter |
|
@derberg Ok I see that documentation pages are broken, I will check this. |
|
@magicmatatjahu sometimes you are so kind ❤️ |
|
you're welcome :) but still some views don't work, for example sticky navbar only works up to a certain height. I need to fix some global styles to make everything work as it should, give me some time. |
Yesss looks way better, thank you for making those changes! Also side note - and we don't have to address this in this PR: Do all the forms on the website do this after submit? (See screenshot below) I think it would be better if we kept the submission notification on the same screen without redirecting to a netlify page. I could submit a separate issue for this
|
|
@mcturco definitely need to be discussed on separate issue, not sure if it can be changed, Netlify Forms are used for it |
|
/rtm |
|
Hello, @derberg! 👋🏼 |
|
@KhudaDad414 something ain't right, have a look at #644 (comment). It was for sure up to date, and ready to merge |
|
@derberg yeah this was happening to me a lot yesterday and was wondering why |
|
@derberg on it. please keep this branch https://github.com/derberg/website-asyncapi/tree/add-newslinkpage for now so I can do some testing :) |
This PR introduces asyncapi.com/newsletter page to make it easy to link to a location where people can subscribe to Newsletter.
We had this page in the past but it was lost during change from Hugo to Next.js
Related issue(s)
See also #33
. TheSee also #33` option will not automatically close the issue after the PR merge. -->