-
-
Notifications
You must be signed in to change notification settings - Fork 741
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: use original anchor tags from the spec #287
fix: use original anchor tags from the spec #287
Conversation
✔️ Deploy Preview for asyncapi-website ready! 🔨 Explore the source changes: 78cb4d8 🔍 Inspect the deploy log: https://app.netlify.com/sites/asyncapi-website/deploys/60d478c14886830008bb4215 😎 Browse the preview: https://deploy-preview-287--asyncapi-website.netlify.app |
this is already done by the automation on spec repo side, when updates to website are pushed |
# AsyncAPI Specification | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@derberg Now that the heading does not break the TOC, should we remove the automation that removes the heading?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yup, less custom actions on the spec is better
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there were some unrelated changes to the spec
Agree but I think they should be there. I'm just copy-pasting whatever was on the spec on tag v2.0.0. These fixes were done on the website and in the spec but they shouldn't have been done on the website. |
I'm putting it back in the end. Don't want to be so picky. |
Description
This PR makes it unnecessary to replace anchor tags like
<a name="definitionsProducer"/>
coming from the specification with something like{# definitionsProducer}
. Therefore, no need for a preprocessing step when releasing a new version of the spec.Related issue(s)
asyncapi/spec#536