Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add jasyncapicmp to the file tools-manual.json #1964

Merged
merged 5 commits into from
Jul 18, 2023

Conversation

siom79
Copy link
Contributor

@siom79 siom79 commented Jul 18, 2023

Description

  • added jasyncapicmp to the file tools-manual.json as the automatic process is currently disabled (as discussed in the slack channel)
  • fixed component ToolsCard.js as language in tools.js is now an object and no longer a string array.

@netlify
Copy link

netlify bot commented Jul 18, 2023

Deploy Preview for asyncapi-website ready!

Name Link
🔨 Latest commit
🔍 Latest deploy log https://app.netlify.com/sites/asyncapi-website/deploys/64b6b64167ff4c04d1ea459e
😎 Deploy Preview https://deploy-preview-1964--asyncapi-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@siom79 siom79 changed the title doc: added jasyncapicmp to the file tools-manual.json docs: added jasyncapicmp to the file tools-manual.json Jul 18, 2023
@github-actions
Copy link

github-actions bot commented Jul 18, 2023

⚡️ Lighthouse report for the changes in this PR:

Category Score
🔴 Performance 46
🟢 Accessibility 98
🟢 Best practices 100
🟢 SEO 100
🔴 PWA 30

Lighthouse ran on https://deploy-preview-1964--asyncapi-website.netlify.app/

@akshatnema akshatnema changed the title docs: added jasyncapicmp to the file tools-manual.json chore: added jasyncapicmp to the file tools-manual.json Jul 18, 2023
@akshatnema akshatnema changed the title chore: added jasyncapicmp to the file tools-manual.json chore: add jasyncapicmp to the file tools-manual.json Jul 18, 2023
Copy link
Member

@derberg derberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, and sorry that you had to add it manually. We have no idea how to approach GitHub to get any hints on what is the future of their search API

@akshatnema wanna have a look?

@akshatnema
Copy link
Member

/rtm

@asyncapi-bot asyncapi-bot merged commit 66297e4 into asyncapi:master Jul 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants