Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add example of version of schema in adeo.yml file #1941

Merged
merged 3 commits into from
Jul 13, 2023
Merged

feat: add example of version of schema in adeo.yml file #1941

merged 3 commits into from
Jul 13, 2023

Conversation

AnimeshKumar923
Copy link
Contributor

Description

Related issue(s)
Fixes #1615

@AnimeshKumar923
Add example of version of schema in adeo.yml file
8617192 
Changes made:
	- This PR fixes the second bullet point of asyncapi#1615.
@netlify
Copy link

netlify bot commented Jul 13, 2023 •
edited
Loading

✅ Deploy Preview for asyncapi-website ready!

Name Link
🔨 Latest commit 29a05d0
🔍 Latest deploy log https://app.netlify.com/sites/asyncapi-website/deploys/64b04be3fe491b0008971d57
😎 Deploy Preview https://deploy-preview-1941--asyncapi-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@AnimeshKumar923 AnimeshKumar923 changed the title fix: Add example of version of schema in adeo.yml file fix: add example of version of schema in adeo.yml file Jul 13, 2023
derberg
derberg requested changes Jul 13, 2023
View reviewed changes
Copy link
Member

@derberg derberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think by accident you removed validation: Based on validation using Confluent Schema Registry. so please bring it back and also you can take it out of Draft so we can approve and merge

@AnimeshKumar923
Copy link
Contributor Author

AnimeshKumar923 commented Jul 13, 2023 •
edited
Loading

I think by accident you removed validation: Based on validation using Confluent Schema Registry. so please bring it back and also you can take it out of Draft so we can approve and merge

Oops! 😱 Let me fix that...

@AnimeshKumar923
Add example of version of schema in adeo.yml file
a3fb042 
Previous changes:
- This PR fixes the second bullet point of asyncapi#1615.

Changes in this commit:
- Fix the line containing `validation` on line 90
  that I accidently deleted. :(
@AnimeshKumar923 AnimeshKumar923 marked this pull request as ready for review July 13, 2023 17:42
@github-actions
Copy link

github-actions bot commented Jul 13, 2023 •
edited
Loading

⚡️ Lighthouse report for the changes in this PR:

Category Score
🔴 Performance 47
🟢 Accessibility 98
🟢 Best practices 100
🟢 SEO 100
🔴 PWA 30

Lighthouse ran on https://deploy-preview-1941--asyncapi-website.netlify.app/

@AnimeshKumar923
Copy link
Contributor Author

Rendered correctly I guess @derberg 😄
Screenshot from 2023-07-13 23-17-39

@derberg derberg changed the title fix: add example of version of schema in adeo.yml file feat: add example of version of schema in adeo.yml file Jul 13, 2023
derberg
derberg approved these changes Jul 13, 2023
View reviewed changes
Copy link
Member

@derberg derberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a 💯 it's looking great

@derberg
Copy link
Member

derberg commented Jul 13, 2023

/rtm

@asyncapi-bot asyncapi-bot merged commit 0c09249 into asyncapi:master Jul 13, 2023
@derberg
Copy link
Member

derberg commented Jul 13, 2023

@allcontributors please add @AnimeshKumar923 for docs,review

@allcontributors allcontributors bot mentioned this pull request Jul 13, 2023
Merged
@allcontributors
Copy link
Contributor

@derberg

I've put up a pull request to add @AnimeshKumar923! 🎉

@AnimeshKumar923
Copy link
Contributor Author

Thanks a 100 it's looking great

Thank you so much 🙏 🙇
Feels great to help here. More to come from my side... 🚀

@AnimeshKumar923 AnimeshKumar923 deleted the adeo-case-second-bullet-point branch July 15, 2023 14:24
@AnimeshKumar923 AnimeshKumar923 restored the adeo-case-second-bullet-point branch July 15, 2023 14:33
@AnimeshKumar923 AnimeshKumar923 deleted the adeo-case-second-bullet-point branch July 15, 2023 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derberg derberg derberg approved these changes

@akshatnema akshatnema Awaiting requested review from akshatnema akshatnema is a code owner

@magicmatatjahu magicmatatjahu Awaiting requested review from magicmatatjahu magicmatatjahu is a code owner

@Mayaleeeee Mayaleeeee Awaiting requested review from Mayaleeeee Mayaleeeee is a code owner

@asyncapi-bot-eve asyncapi-bot-eve Awaiting requested review from asyncapi-bot-eve asyncapi-bot-eve is a code owner

Assignees
No one assigned
Labels
ready-to-merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[📑 Docs]: improve adeo case study
3 participants
@AnimeshKumar923 @derberg @asyncapi-bot