-
-
Notifications
You must be signed in to change notification settings - Fork 736
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add .prettierignore
to prevent autoformatting
#1934
fix: add .prettierignore
to prevent autoformatting
#1934
Conversation
✅ Deploy Preview for asyncapi-website ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-1934--asyncapi-website.netlify.app/ |
nifty, wasn't aware of it, @akshatnema what do you think? |
I think, if lots of people facing the error, let's fix it out regarding prettier instead of defining |
@akshatnema yeah but difference is that |
Yeah, we will not have autoformatters issues again in the repository. Although it is not a good practice, but later on with proper discussion with community, we can add |
@akshatnema but I'm only referring to prettier, to block it for now. have a look at #1640 (comment) |
Yes exactly, their are other code formatters but most of developers use prettier and unknowingly they it makes unwanted changes in the PR so why don't we just ignore the whole thing with .prettierignore |
Yeah, it will only block prettier, but a developer can use other code formatters inside IDE also. |
If you wish to have |
@akshatnema I have added .prettierignore for code editors! |
@akshatnema does it mean you accept the change or? 😄 |
Yeah, I accept the changes 😄 |
.prettierignore
to prevent autoformatting
/rtm 👋🏼 good bye unexpected quotation changes or semi-colons additions 😄 |
@allcontributors please add @vishvamsinh28 for code |
I've put up a pull request to add @vishvamsinh28! 🎉 |
In this pr I have added .prettierignore which disables the code formatter for this project.
Fixes #1933