Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(blog): docs June report #1908

Merged
merged 12 commits into from
Jul 11, 2023
Merged

chore(blog): docs June report #1908

merged 12 commits into from
Jul 11, 2023

Conversation

quetzalliwrites
Copy link
Member

AsyncAPI Docs June Report

@quetzalliwrites quetzalliwrites added 📑 docs area/docs Specify what technical area given issue relates to. Its goal is to ease filtering good first issues. labels Jul 7, 2023
@quetzalliwrites quetzalliwrites self-assigned this Jul 7, 2023
@netlify
Copy link

netlify bot commented Jul 7, 2023 •
edited
Loading

✅ Deploy Preview for asyncapi-website ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 7959e55
🔍 Latest deploy log https://app.netlify.com/sites/asyncapi-website/deploys/64acfbc1e1f2f2000877fa79
😎 Deploy Preview https://deploy-preview-1908--asyncapi-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@quetzalliwrites
Copy link
Member Author

Yo @derberg or @akshatnema, may i also get an approval from one of you folks? Since we need 2 approvals, I need more than just Thulie's 😄

@github-actions
Copy link

github-actions bot commented Jul 7, 2023 •
edited
Loading

⚡️ Lighthouse report for the changes in this PR:

Category Score
🔴 Performance 29
🟢 Accessibility 98
🟢 Best practices 100
🟢 SEO 100
🔴 PWA 30

Lighthouse ran on https://deploy-preview-1908--asyncapi-website.netlify.app/

@github-actions
Copy link

github-actions bot commented Jul 7, 2023

⚡️ Lighthouse report for the changes in this PR:

Category Score
🔴 Performance 45
🟢 Accessibility 98
🟢 Best practices 100
🟢 SEO 100
🔴 PWA 30

Lighthouse ran on https://deploy-preview-1908--asyncapi-website.netlify.app/

AnimeshKumar923
AnimeshKumar923 reviewed Jul 7, 2023
View reviewed changes
Copy link
Contributor

@AnimeshKumar923 AnimeshKumar923 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Reviewed the blog from my side.
  • @alequetzalli Please have a look and provide feedback to it from your side. Thank you!

pages/blog/2023-june-docs-report.md Show resolved Hide resolved
pages/blog/2023-june-docs-report.md Outdated Show resolved Hide resolved
pages/blog/2023-june-docs-report.md Show resolved Hide resolved
pages/blog/2023-june-docs-report.md Outdated Show resolved Hide resolved
quetzalliwrites and others added 2 commits July 8, 2023 08:02
@quetzalliwrites @AnimeshKumar923
Update pages/blog/2023-june-docs-report.md
59707fa 
Co-authored-by: Animesh Kumar <kumaranimesh923@gmail.com>
@quetzalliwrites @AnimeshKumar923
Update pages/blog/2023-june-docs-report.md
10e78a7 
Co-authored-by: Animesh Kumar <kumaranimesh923@gmail.com>
@AnimeshKumar923
Copy link
Contributor

LGTM! 🚀 😄

quetzalliwrites and others added 3 commits July 10, 2023 09:41
@quetzalliwrites @thulieblack
add comma
7693544 
Co-authored-by: V Thulisile Sibanda <66913810+thulieblack@users.noreply.github.com>
@quetzalliwrites @thulieblack
spelling fix
20dedbc 
Co-authored-by: V Thulisile Sibanda <66913810+thulieblack@users.noreply.github.com>
@quetzalliwrites
Merge branch 'master' into June-docs-report-blog
bdd95f7
@quetzalliwrites
Copy link
Member Author

yo @derberg, reminder that we need your approval on this too 😄

derberg
derberg reviewed Jul 10, 2023
View reviewed changes
Copy link
Member

@derberg derberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thulieblack as co-codeowner for blog you also have to approve.

@quetzalliwrites
Copy link
Member Author

LOL I am not worried about @thulieblack forgetting to approve this... I was worried about YOU lukaszzzz 😂😂😂

@derberg
Copy link
Member

derberg commented Jul 10, 2023

yeah, I'm more concerned she is not showing up 👇🏼

Screenshot 2023-07-10 at 19 04 22

normally if she would be required to approve, she should be there, so I'm afraid something wrong with CODEOWNER structure 🤷🏼 so I'm pinging her but don't know if her approval will work

@quetzalliwrites
Copy link
Member Author

yeah, I'm more concerned she is not showing up 👇🏼
normally if she would be required to approve, she should be there, so I'm afraid something wrong with CODEOWNER structure 🤷🏼 so I'm pinging her but don't know if her approval will work

oooooh I see that now! yes, that is wrong! I am glad you noticed it, so we can fix that 😄

@quetzalliwrites
Copy link
Member Author

Screen Shot 2023-07-10 at 10 07 52 AM

i don't understand why Thulie isn't showing up... looking at the codeowners file now and it looks correct to me 🥺

@derberg
Copy link
Member

derberg commented Jul 10, 2023

that is the problem, it looks good to me to 😆 so let's wait for @thulieblack and see if that works. Hoping 🤞🏼 it is just UI glitch

@derberg
Copy link
Member

derberg commented Jul 10, 2023

oh my god, just unlocked new knowledge 😆

so in PR in Files changed when you hover over the "key lock" icon, it tells you who is the codeowner of given file

Screenshot 2023-07-10 at 19 22 03

so yeah, all looks good, maybe just on Mondays I'm sceptical, and only on mondays GitHub UI is like me 😄 so yeah, @thulieblack approval will solve the problem for sure 😄

@quetzalliwrites
Copy link
Member Author

Oh wow super cool!!!!! I also had no idea that hovering over the lock icon would show me the owners of the file 🔥🔥🔥

thulieblack
thulieblack approved these changes Jul 11, 2023
View reviewed changes
Copy link
Member

@thulieblack thulieblack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👌🏿

@thulieblack
Copy link
Member

/rtm

@asyncapi-bot asyncapi-bot merged commit bd1c6bf into asyncapi:master Jul 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AnimeshKumar923 AnimeshKumar923 AnimeshKumar923 left review comments

@derberg derberg derberg approved these changes

@thulieblack thulieblack thulieblack approved these changes

@akshatnema akshatnema Awaiting requested review from akshatnema akshatnema is a code owner

@magicmatatjahu magicmatatjahu Awaiting requested review from magicmatatjahu magicmatatjahu is a code owner

@asyncapi-bot-eve asyncapi-bot-eve Awaiting requested review from asyncapi-bot-eve asyncapi-bot-eve is a code owner

Assignees

@quetzalliwrites quetzalliwrites

Labels
area/docs Specify what technical area given issue relates to. Its goal is to ease filtering good first issues. 📑 docs ready-to-merge
Projects
AsyncAPI Docs Board
Status: Community PR under Review 🧐
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@quetzalliwrites @AnimeshKumar923 @derberg @thulieblack @asyncapi-bot