feat: update the banner to promote London CFP on the website #1825
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for asyncapi-website ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-1825--asyncapi-website.netlify.app/ |
derberg
reviewed
Jun 22, 2023
| @@ -8,8 +8,8 @@ function shouldShowBanner() { | |||
| const month = new Date().getUTCMonth(); | |||
There was a problem hiding this comment.
new function
function shouldShowBanner(cfpDeadline) {
const currentDate = new Date(); // Get the current date
const deadline = new Date(cfpDeadline); // Convert the cfpDeadline string to a Date object
// Check if the current date is after the deadline
if (currentDate > deadline) {
return false;
}
return true;
}
| //month=4 is May | ||
| if (year > 2023 || month !== 4) { | ||
| //month=6 is June | ||
| if (year > 2023 || month !== 6) { |
There was a problem hiding this comment.
then banner will not show it in July either
I suggested changes that make the code suggestions much easier to maintain and banner to be more accurate, precise to a month day and not month only
Co-authored-by: Lukasz Gornicki <lpgornicki@gmail.com>
Co-authored-by: Lukasz Gornicki <lpgornicki@gmail.com>
|
/rtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR with the update of the CFP banner with the London details.