feat: adding unit tests for support-us,Testimonial and JobSummary component #1813
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for asyncapi-website ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-1813--asyncapi-website.netlify.app/ |
akshatnema
requested changes
Jul 9, 2023
components/SupportUs.js
Outdated
Comment on lines
3
to
61
| export const supportItems = [ | ||
| { | ||
| href: 'https://slack.com/media-kit', | ||
| target: '_blank', | ||
| className: 'block relative text-center w-2/3 px-4 py-4 sm:p-0 sm:w-1/3 md:w-1/3 lg:w-1/5', | ||
| rel: 'noopener noreferrer', | ||
| src: '/img/supportus/slack.webp', | ||
| title: 'Slack - Free Standard Subscription.' | ||
| }, | ||
| { | ||
| href: 'https://toast.ninja/', | ||
| target: '_blank', | ||
| className: 'block relative text-center w-2/3 px-4 py-4 sm:p-0 sm:w-1/3 md:w-1/3 lg:w-1/5', | ||
| rel: 'noopener noreferrer', | ||
| src: '/img/supportus/toast.webp', | ||
| title: 'Toast - Free services.' | ||
| }, | ||
| { | ||
| href: 'https://www.netlify.com/', | ||
| target: '_blank', | ||
| className: 'block relative text-center w-2/3 px-4 py-4 sm:p-0 sm:w-1/3 md:w-1/3 lg:w-1/5', | ||
| rel: 'noopener noreferrer', | ||
| src: '/img/supportus/netlify.webp', | ||
| title: 'Netlify - Free website deployment.' | ||
| }, | ||
| { | ||
| href: 'https://sonarcloud.io/', | ||
| target: '_blank', | ||
| className: 'block relative text-center w-2/3 px-4 py-4 sm:p-0 sm:w-1/3 md:w-1/3 lg:w-1/5', | ||
| rel: 'noopener noreferrer', | ||
| src: '/img/supportus/sonarcloud.webp', | ||
| title: 'Sonarcloud - Free tier for automated project scanning.' | ||
| }, | ||
| { | ||
| href: 'https://www.digitalocean.com/press/', | ||
| target: '_blank', | ||
| className: 'block relative text-center w-2/3 px-4 py-4 sm:p-0 sm:w-1/3 md:w-1/3 lg:w-1/5', | ||
| rel: 'noopener noreferrer', | ||
| src: '/img/supportus/digitalocean.webp', | ||
| title: 'DigitalOcean - 500 dollars on cloud services.' | ||
| }, | ||
| { | ||
| href: 'https://restream.io/', | ||
| target: '_blank', | ||
| className: 'block relative text-center w-2/3 px-4 py-4 sm:p-0 sm:w-1/3 md:w-1/3 lg:w-1/5', | ||
| rel: 'noopener noreferrer', | ||
| src: '/img/supportus/restream.webp', | ||
| title: 'Restream - Free professional plan subscription.' | ||
| }, | ||
| { | ||
| href: 'https://sessionize.com/', | ||
| target: '_blank', | ||
| className: 'block relative text-center w-2/3 px-4 py-4 sm:p-0 sm:w-1/3 md:w-1/3 lg:w-1/5', | ||
| rel: 'noopener noreferrer', | ||
| src: '/img/supportus/sessionize.webp', | ||
| title: 'Sessionize - Free community license for AACoT Madrid.' | ||
| } | ||
| ]; | ||
|
|
There was a problem hiding this comment.
Make this static array part of separate file and use it in both components and test files.
components/SupportUs.js
Outdated
| { | ||
| href: 'https://www.netlify.com/', | ||
| target: '_blank', | ||
| className: 'block relative text-center w-2/3 px-4 py-4 sm:p-0 sm:w-1/3 md:w-1/3 lg:w-1/5', |
There was a problem hiding this comment.
className should not be the part of this array. Since, these are CSS properties, add the classes in <a> tag only.
There was a problem hiding this comment.
I checked the website <a> tag had consistent classes , however <div> and <img> had different classNames , thus I added classes for img , in the array so that it maps correct classes and thus renders the component as it is .
akshatnema
reviewed
Jul 10, 2023
cypress/test/Testimonial.cy.js
Outdated
| text: 'This is a test testimonial.', | ||
| authorName: 'John Doe', | ||
| authorDescription: 'CEO at Company', | ||
| authorAvatar: '/img/avatar.jpg', |
There was a problem hiding this comment.
Correct the image path here.
akshatnema
reviewed
Jul 10, 2023
Co-authored-by: Akshat Nema <76521428+akshatnema@users.noreply.github.com>
akshatnema
approved these changes
Jul 11, 2023
|
/rtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR includes , tests for 3 components : SupportUs, Testimonial and JobSummary components .
SupportUs component , is a list of tools and technologies that AsyncAPI is supported by , earlier this component had a lot of nested tags , and thus I created an array with link tags and all the necessary attributes that are required for the list . This makes the code modular and makes it easier for us to write the test code .
The testcases I have written for this component are as follows :
-Testimonial component , For this component the testcases I have written are as follows :
JobSummary component , For this component the testcases I have written are as follows :
Related issue(s)
fixes #1812