Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adding unit tests for roadmap component #1791

Merged
merged 16 commits into from
Jul 8, 2023

Conversation

reachaadrika
Copy link
Contributor

@reachaadrika reachaadrika commented Jun 15, 2023

Description

  • Roadmap component of the website has 3 main components within it which are as follows :
  • RoadmapColumn.js : This is the main component and also houses RoadmapList component within it . For this component the main tests that I included were as follows :
  1. renders the RoadmapColumn component with title and description
  2. renders the RoadmapList component within RoadmapColumn
  3. renders the correct number of items in RoadmapList

NOTE : This component had assertions within it

Here the matched components are hidden and thus are not visible here.
image

-RoadmapList : This component displays the items in a list format . For this component I have added following tests .

  1. renders the component with items
  2. renders the component with collapsed items

NOTE : This component had assertions within it

Here the matched components are hidden and thus are not visible here.
image

  • RoadmapItem : Each item in this component . Following are the tests that I have added for this component :
  1. renders the component and displays item title
    image

Related issue(s)
fixes #1790

@netlify
Copy link

netlify bot commented Jun 15, 2023

Deploy Preview for asyncapi-website ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 7985cbb
🔍 Latest deploy log https://app.netlify.com/sites/asyncapi-website/deploys/64a9303d8419d40008720893
😎 Deploy Preview https://deploy-preview-1791--asyncapi-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@reachaadrika reachaadrika changed the title add tests for roadmap components feat: adding unit tests for roadmap component Jun 15, 2023
@github-actions
Copy link

github-actions bot commented Jun 15, 2023

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 54
🟢 Accessibility 98
🟢 Best practices 100
🟢 SEO 100
🔴 PWA 30

Lighthouse ran on https://deploy-preview-1791--asyncapi-website.netlify.app/

@akshatnema akshatnema added the gsoc This label should be used for issues or discussions related to ideas for Google Summer of Code label Jun 16, 2023
import { mount } from '@cypress/react';
import RoadmapItem from '../../../components/roadmap/RoadmapItem'

describe('RoadmapItem', () => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RoadmapItem should contain a case for clicking the Item and it opens a modal containing necessary details for each item.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure

cypress/test/Roadmap/RoadmapColumn.cy.js Outdated Show resolved Hide resolved
Copy link
Member

@akshatnema akshatnema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/rtm

@akshatnema
Copy link
Member

/rtm

@asyncapi-bot asyncapi-bot merged commit 7541555 into asyncapi:master Jul 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gsoc This label should be used for issues or discussions related to ideas for Google Summer of Code ready-to-merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add unit tests for roadmap component
3 participants