fix: updated tools workflow #1627
Conversation
Signed-off-by: akshatnema <20bcs022@iiitdmj.ac.in>
✅ Deploy Preview for asyncapi-website ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
config/tools-automated.json
Outdated
| { | ||
| "title": "Golang AsyncAPI Code Generator", | ||
| "description": "Generate Go client and server boilerplate from AsyncAPI specifications. Can be called from `go generate` without requirements.\n", | ||
| "links": { | ||
| "repoUrl": "https://github.com/lerenn/asyncapi-codegen" | ||
| }, | ||
| "filters": { | ||
| "language": "golang", | ||
| "categories": [ | ||
| "code-generator" | ||
| ], | ||
| "hasCommercial": false, | ||
| "isAsyncAPIOwner": false | ||
| } | ||
| }, |
There was a problem hiding this comment.
@derberg Many of the tools like this are no more recognizable from GitHub code search. I don't know why but for every GET call of API, there are only 14 results.
There was a problem hiding this comment.
for now just update in the way to make sure it is not removed and we can merge I guess
|
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-1627--asyncapi-website.netlify.app/ |
| @@ -1,4 +1,5 @@ | |||
| const axios = require('axios'); | |||
| require('dotenv').config() | |||
There was a problem hiding this comment.
It's needed because I whenever this script in local, I've to replace the process.env with my token there. This file is not part of next js folders so it doesn't take the variables from .env or .env.local by default.
There was a problem hiding this comment.
but we do not have .env in website, right?
There was a problem hiding this comment.
Yeah, this file is part of .gitignore, but we need some env variables to run the scripts or run Netlify functions. So, this file shouldn't be part of GitHub repo.
There was a problem hiding this comment.
but these are already in Netlify
sorry but I really don't get it why we need i here. I know people use .env if they have a lot of env variables that they need to pass locally to run some stuff. But we do not have it right? and no need to read it?
There was a problem hiding this comment.
but these are already in Netlify
These files are not part of Netlify or Next js build, so they won't be able to take .env or .env.local files from the directory for local environment setup.
We also know that tools workflow file run in local dev setup only, not in Github actions workflow, so to provide it with proper env setup, we can add this line to get the variables from .env file. Also, it won't affect any changes or usage inside Github actions as well.
|
@derberg I recently checked with the Github API that they have improved their Github Search API results and it's working fine with correct results. Hence, I will enable the workflow inside website repository after this PR so that we don't have to do this step manually. |
|
/rtm |
Description
Updated tools inside the website and refactored the code of the tools script.
Related issue(s)
Fixes #1604