Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add Anypoint MQ protocol to list of supported bindings #545

Merged
merged 22 commits into from
Sep 16, 2021
Merged

feat: add Anypoint MQ protocol to list of supported bindings #545

merged 22 commits into from
Sep 16, 2021

Conversation

GeraldLoeffler
Copy link
Contributor

title: "Create Anypoint MQ protocol"

Added protocol anypointmq to the spec.
A separate PR will be submitted against the bindings repo https://github.com/asyncapi/bindings for the corresponding bindings definitions.

Related issue(s):
#514

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@GeraldLoeffler GeraldLoeffler changed the title Anypoint MQ protocol in spec feat: add Anypoint MQ protocol to spec May 26, 2021
@GeraldLoeffler
Copy link
Contributor Author

GeraldLoeffler commented May 26, 2021 •
edited
Loading

@derberg : please add Strawman (RFC 0) label to this PR (i don't seem to be able to do that).

@GeraldLoeffler GeraldLoeffler mentioned this pull request May 26, 2021
Closed
@fmvilas fmvilas added the 💭 Strawman (RFC 0) RFC Stage 0 (See CONTRIBUTING.md) label May 26, 2021
fmvilas
fmvilas reviewed May 26, 2021
View reviewed changes
Copy link
Member

@fmvilas fmvilas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I'm just missing the protocol bindings in the github.com/asyncapi/bindings repo.

@GeraldLoeffler
Copy link
Contributor Author

Looks good to me. I'm just missing the protocol bindings in the github.com/asyncapi/bindings repo.

@fmvilas : i've now pushed the matching PR against the bindings repo: asyncapi/bindings#63

@GeraldLoeffler GeraldLoeffler mentioned this pull request May 28, 2021
Closed
@GeraldLoeffler GeraldLoeffler mentioned this pull request Jun 17, 2021
Closed
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@derberg derberg added 💡 Proposal (RFC 1) RFC Stage 1 (See CONTRIBUTING.md) and removed 💭 Strawman (RFC 0) RFC Stage 0 (See CONTRIBUTING.md) labels Sep 1, 2021
@derberg
Copy link
Member

derberg commented Sep 1, 2021

@GeraldLoeffler lgtm but please change base branch from master to 2021-09-release

@GeraldLoeffler GeraldLoeffler changed the base branch from master to 2021-09-release September 2, 2021 14:07
@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 2, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@GeraldLoeffler
Copy link
Contributor Author

GeraldLoeffler commented Sep 2, 2021 •
edited
Loading

okay @derberg , i've managed to change the base branch of this PR from master to 2021-09-release (and successfully battled the spurious file change complications this caused): done

@derberg derberg changed the title feat: add Anypoint MQ protocol to spec feat: add Anypoint MQ protocol to list of supported bindings Sep 15, 2021
derberg
derberg approved these changes Sep 15, 2021
View reviewed changes
Copy link
Member

@derberg derberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, we just need to first merge asyncapi/spec-json-schemas#90, then I will help with PR to the parser and can move this proposal to stage 3 and merge 🥳

@fmvilas anything from your side?

fmvilas
fmvilas approved these changes Sep 15, 2021
View reviewed changes
Copy link
Member

@fmvilas fmvilas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ship it!

@derberg derberg added 🏁 Accepted (RFC 3) RFC Stage 3 (See CONTRIBUTING.md) and removed 💡 Proposal (RFC 1) RFC Stage 1 (See CONTRIBUTING.md) labels Sep 16, 2021
@derberg derberg merged commit 88e2b08 into asyncapi:2021-09-release Sep 16, 2021
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 2.2.0-2021-09-release.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@derberg
Copy link
Member

derberg commented Sep 16, 2021

@GeraldLoeffler release candidate is released, if you want to suggest some specific information in draft of release notes (you can look at previous release notes) feel free to do it, as code suggestion or just a comment

@derberg derberg mentioned this pull request Sep 28, 2021
Merged
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 2.2.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@jonaslagoni jonaslagoni mentioned this pull request Nov 9, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] approved these changes

@derberg derberg derberg approved these changes

@fmvilas fmvilas fmvilas approved these changes

Assignees
No one assigned
Labels
🏁 Accepted (RFC 3) RFC Stage 3 (See CONTRIBUTING.md) released on @2021-09-release released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@GeraldLoeffler @derberg @asyncapi-bot @fmvilas