docs: explain how JSON Schema files are served #229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derberg
reviewed
Jun 14, 2022
There was a problem hiding this comment.
2 tiny comments
@dalelane @fmvilas do you need something more?
@jonaslagoni you probably like it is almost there 😄
schemas/README.md
Outdated
| @@ -0,0 +1,14 @@ | |||
| # AsyncAPI JSON Schema definitions | |||
|
|
|||
| All the JSON Schema documents for validating AsyncAPI documents are located here. | |||
There was a problem hiding this comment.
here - did you want to add a link or specify here as here in this repository?
There was a problem hiding this comment.
The second; here in this repository. I'm going to clarify it then 👍
There was a problem hiding this comment.
done! let me know if it sounds better now.
Co-authored-by: Lukasz Gornicki <lpgornicki@gmail.com>
derberg
previously approved these changes
Jun 14, 2022
|
/rtm |
|
Kudos, SonarCloud Quality Gate passed!
|
|
/rtm |
|
🎉 This PR is included in version 3.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a
README.mdfile under/schemasdirectory so we can explain what's the preferable way for downloading/using AsyncAPI JSON Schema documents.Related issue(s)
asyncapi/website#680 (comment)