Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inconsistantly defined $ref for server #164

Closed
jonaslagoni opened this issue Feb 3, 2022 · 1 comment · Fixed by #128
Closed

Inconsistantly defined $ref for server #164

jonaslagoni opened this issue Feb 3, 2022 · 1 comment · Fixed by #128
Labels
bug Something isn't working

Comments

@jonaslagoni
Copy link
Member

Describe the bug

In b51f0aa#diff-c42eed206b44fe4fa90f1635ff156f9804ae2450b901771b9c4d6db5188d640cR173 we released a property to the server object, to contain $ref instead of using the existing reference definition.

This results in an inconsistency in how references are defined.

Expected behavior

All references should use the same reference definition.
@jonaslagoni jonaslagoni added the bug Something isn't working label Feb 3, 2022
This was referenced Feb 3, 2022
Merged
Closed
@jonaslagoni jonaslagoni mentioned this issue Mar 18, 2022
Merged
@jonaslagoni
Copy link
Member Author

This was solved in #128

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat!: split out definitions jonaslagoni/spec-json-schemas
1 participant
@jonaslagoni