Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: add fromURL and fromFile utils #610

Merged
merged 2 commits into from
Sep 15, 2022
Merged

refactor: add fromURL and fromFile utils #610

merged 2 commits into from
Sep 15, 2022

Conversation

magicmatatjahu
Copy link
Member

@magicmatatjahu magicmatatjahu commented Sep 14, 2022 •
edited
Loading

Description

  • add fromURL and fromFile utils:
    • fromURL is util which operates on HTTP sources - old parseFromURL function
    • fromFile is util which operates on filesystem sources.
  • change path to the source in ParseOptions and ValidateOptions
  • add tests
  • update Readme.md

cc @smoya

Related issue(s)
Part of #481
Part of #482

@magicmatatjahu magicmatatjahu added the enhancement New feature or request label Sep 14, 2022
smoya
smoya reviewed Sep 14, 2022
View reviewed changes
src/spectral.ts
@@ -20,6 +20,8 @@ function configureRuleset(parser: Parser): RulesetDefinition {
rules: {
'asyncapi-is-asyncapi': asyncApi2IsAsyncApi(),
'asyncapi-schemas-v2': asyncApi2SchemaParserRule(parser),
// operationId is optional field
'asyncapi-operation-operationId': 'warn',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

smoya
smoya approved these changes Sep 14, 2022
View reviewed changes
Copy link
Member

@smoya smoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀🌔

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@magicmatatjahu
Copy link
Member Author

/rtm

@asyncapi-bot asyncapi-bot merged commit d33debd into asyncapi:next-major Sep 15, 2022
@magicmatatjahu magicmatatjahu deleted the next/fetch-file-utils branch September 15, 2022 07:41
magicmatatjahu added a commit to magicmatatjahu/parser-js that referenced this pull request Oct 3, 2022
@magicmatatjahu
refactor: add fromURL and fromFile utils (asyncapi#610)
017458d
derberg pushed a commit that referenced this pull request Oct 4, 2022
@magicmatatjahu @derberg
refactor: add fromURL and fromFile utils (#610)
ac49c9f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smoya smoya smoya approved these changes

@fmvilas fmvilas Awaiting requested review from fmvilas fmvilas is a code owner

@jonaslagoni jonaslagoni Awaiting requested review from jonaslagoni jonaslagoni is a code owner

@derberg derberg Awaiting requested review from derberg derberg is a code owner

@asyncapi-bot-eve asyncapi-bot-eve Awaiting requested review from asyncapi-bot-eve asyncapi-bot-eve is a code owner

Assignees
No one assigned
Labels
enhancement New feature or request ready-to-merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@magicmatatjahu @smoya @asyncapi-bot