ci: add next-major branch to the list of branches to release #442

smoya · 2022-01-12T13:14:40Z

Description

Relates to #401.
This change will allow next-major branch to be released on each merge, so users can use and test the new work during the development phase.

Related issue(s)
#401

cc @derberg @jonaslagoni

jonaslagoni · 2022-01-12T13:49:52Z

package.json

+      {
+        "name": "intent-api",
+        "prerelease": true


Can CI handle double prerelease @derberg? 🤔

yes, it is ready as it was required for React component and the 2.0 prerelease phase with next branch.

We only need to agree on bumping strategy. In React for example every single release candidate goes to html-template, so on master we had to make sure that whenever you release to master, main release is not bumped in html-template -> https://github.com/asyncapi/asyncapi-react/blob/master/.github/workflows/bump.yml#L32

@jonaslagoni but I guess we do not want to bump it automatically anywhere. I don't see a point at this moment

What about the generator? Had in mind we integrated it for templates to use the new API ASAP.

all templates follow guidelines to set that they are always compatible with generator prior 2.0
so yeah, pushing new Parser would be breaking change, unless you are thinking about release candidates in generator too 🤔

well, I love the idea!
but 😄 I don't think my bumper supports custom branches 😆

@smoya ping as not sure if you saw it. I think this one is not just nice to have, but tbh a must-have, otherwise testing new functions in templates will be complicated

@smoya @jonaslagoni good news, I just released v4 of the bumper action

https://github.com/derberg/npm-dependency-manager-for-your-github-org

Now it supports new prop for config - base_branch

So once we merge this PR, and create branch next-major, please open another PR against this new release branch and make sure that the bump.yml workflow:

its version in next-major branch will react to commits to next-major and not master

add base_branch: next-major. This will force bumper to bump Parser in dependants that also have next-major branch, and PR with bump will be opened against next-major, which means that after merge the release candidate will be published for a given project, if configured

React component does it already, but base_branch is not used -> https://github.com/asyncapi/asyncapi-react/blob/next/.github/workflows/bump.yaml

makes sense?

That's awesome! Yeah makes totally sense. Thanks for the work you did in the bumper action!
Let's do that thing you suggest then @derberg !

It's done here: #468 @derberg @jonaslagoni

derberg · 2022-01-12T13:58:37Z

package.json

@@ -90,6 +90,10 @@
      {
        "name": "2021-09-release",
        "prerelease": true
+      },
+      {
+        "name": "intent-api",


Suggested change

"name": "intent-api",

"name": "next",

please rename it to next. This is standard recommended by semantic-release and npm. And release pipeline supports it.

also from user perspective, at the end it is about next major release. We will not release only intent API in 2.0 of the Parser, there are some other stuff I bet we want to push in

anyway 🤷🏼

Truly, TS is just far better at dictating types than JSDoc 🤷

please rename it to next. This is standard recommended by semantic-release and npm. And release pipeline supports it.

also from user perspective, at the end it is about next major release. We will not release only intent API in 2.0 of the Parser, there are some other stuff I bet we want to push in

Then I think it's better to use next-major as also specified in semantic-release doc.

but why 😄 if recommended is next 😄 and then you need to update global workflow everywhere https://github.com/asyncapi/.github/blob/master/.github/workflows/if-nodejs-release.yml#L12. Why not just next and follow the best practices we got from working with react already?

@jonaslagoni actually I did not understand your question properly, now saw below after changes from Sergio.

{ "name": "2021-09-release", "prerelease": true }, { "name": "next-major", "prerelease": true }

Tbh I'm not sure, we need to check docs of semantic-release package to be 100% sure.

next-major is standard as well in semantic release. It is intended to be used for that, major releases, which it obviously fits better to our case. We wont block other future releases (minor or patches) may happen before the major.

I didnt checked the ci script you linked until this right moment.

Its not about discarding what you recommend to do randomly 😅. I just read your comment, learned about semantic release next branch mechanism, and thats where I found that the next-major tag its standard as well as release.

Btw, I created this PR asyncapi/.github#121 so we add all default semantic-release branches to the release workflow. cc @derberg

@smoya did you maybe have a chance to check docs, of semantic-release if it comes to supporting multiple prereleases? I bet it is possible, but just to be 100% sure

@smoya did you maybe have a chance to check docs, of semantic-release if it comes to supporting multiple prereleases? I bet it is possible, but just to be 100% sure

It does not explicitly say it, however, I understand it happens as I don't see why it wouldn't.
The release workflow will run against just one branch, so the script will check if the branch needs to be pre-released or not based on the prerelease: true property in package.json.

But in this case, why would we need a prerelease for the next-major branch?

package.json

smoya · 2022-02-07T19:18:35Z

/rtm

smoya · 2022-02-07T20:02:06Z

@asyncapi-bot why don't you merge my PR? :(

EDIT:

2022-02-07T19:29:24.895Z INFO  Current PR status: mergeable_state: behind
2022-02-07T19:29:24.895Z INFO  PR not ready to be merged after 20 tries

You bold @asyncapi-bot ❤️

sonarqubecloud · 2022-02-07T20:04:23Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

smoya · 2022-02-07T20:07:26Z

/rtm

asyncapi-bot · 2022-04-14T10:21:06Z

🎉 This PR is included in version 1.15.0-2022-04-release.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

asyncapi-bot · 2022-04-27T14:51:19Z

🎉 This PR is included in version 1.15.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

ci: add intent-api branch to the list of branches to release

fad03ff

jonaslagoni reviewed Jan 12, 2022

View reviewed changes

derberg reviewed Jan 12, 2022

View reviewed changes

rename branch to next-major

24652c7

smoya requested a review from derberg January 12, 2022 15:54

smoya changed the title ~~ci: add intent-api branch to the list of branches to release~~ ci: add next-major branch to the list of branches to release Jan 12, 2022

smoya mentioned this pull request Jan 12, 2022

fix: include all semantic-release default branches for the release workflow + fix Genie asyncapi/.github#121

Merged

derberg mentioned this pull request Feb 5, 2022

ci: ignore testing for bots in certain PRs asyncapi/.github#128

Merged

smoya requested a review from jonaslagoni February 7, 2022 12:50

jonaslagoni reviewed Feb 7, 2022

View reviewed changes

package.json Outdated Show resolved Hide resolved

smoya requested a review from jonaslagoni February 7, 2022 13:44

jonaslagoni approved these changes Feb 7, 2022

View reviewed changes

asyncapi-bot added the ready-to-merge label Feb 7, 2022

github-actions bot approved these changes Feb 7, 2022

View reviewed changes

asyncapi-bot added the autoapproved label Feb 7, 2022

github-actions bot approved these changes Feb 7, 2022

View reviewed changes

Merge branch 'master' into intent-api

d1e7372

asyncapi-bot removed the ready-to-merge label Feb 7, 2022

github-actions bot approved these changes Feb 7, 2022

View reviewed changes

asyncapi-bot added the ready-to-merge label Feb 7, 2022

asyncapi-bot merged commit 8369b10 into asyncapi:master Feb 7, 2022

github-actions bot approved these changes Feb 7, 2022

View reviewed changes

smoya deleted the intent-api branch February 7, 2022 20:08

asyncapi-bot added the released on @2022-04-release label Apr 14, 2022

asyncapi-bot added the released label Apr 27, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ci: add next-major branch to the list of branches to release #442

ci: add next-major branch to the list of branches to release #442

smoya commented Jan 12, 2022 •

edited

Loading

jonaslagoni Jan 12, 2022

derberg Jan 12, 2022

derberg Jan 12, 2022

jonaslagoni Jan 12, 2022

derberg Jan 12, 2022

derberg Jan 12, 2022

derberg Jan 13, 2022

derberg Feb 5, 2022 •

edited

Loading

smoya Feb 7, 2022 •

edited

Loading

smoya Feb 7, 2022

derberg Jan 12, 2022

jonaslagoni Jan 12, 2022

derberg Jan 12, 2022

jonaslagoni Jan 12, 2022 •

edited

Loading

smoya Jan 12, 2022

derberg Jan 12, 2022

smoya Jan 12, 2022

smoya Jan 12, 2022 •

edited

Loading

derberg Jan 13, 2022

smoya Jan 13, 2022 •

edited

Loading

smoya commented Feb 7, 2022

smoya commented Feb 7, 2022 •

edited

Loading

sonarqubecloud bot commented Feb 7, 2022

smoya commented Feb 7, 2022

asyncapi-bot commented Apr 14, 2022

asyncapi-bot commented Apr 27, 2022

ci: add next-major branch to the list of branches to release #442

ci: add next-major branch to the list of branches to release #442

Conversation

smoya commented Jan 12, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

derberg Feb 5, 2022 • edited Loading

Choose a reason for hiding this comment

smoya Feb 7, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jonaslagoni Jan 12, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

smoya Jan 12, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

smoya Jan 13, 2022 • edited Loading

Choose a reason for hiding this comment

smoya commented Feb 7, 2022

smoya commented Feb 7, 2022 • edited Loading

sonarqubecloud bot commented Feb 7, 2022

smoya commented Feb 7, 2022

asyncapi-bot commented Apr 14, 2022

asyncapi-bot commented Apr 27, 2022

smoya commented Jan 12, 2022 •

edited

Loading

derberg Feb 5, 2022 •

edited

Loading

smoya Feb 7, 2022 •

edited

Loading

jonaslagoni Jan 12, 2022 •

edited

Loading

smoya Jan 12, 2022 •

edited

Loading

smoya Jan 13, 2022 •

edited

Loading

smoya commented Feb 7, 2022 •

edited

Loading