Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add required field management in csharp newtonsoft serializer #2117

Merged
merged 9 commits into from
Jan 25, 2025
Merged

feat: add required field management in csharp newtonsoft serializer #2117

merged 9 commits into from
Jan 25, 2025

Conversation

fr-th
Copy link
Contributor

@fr-th fr-th commented Oct 29, 2024

Description

When generating c# model with newtonsoft serialization, an option now allows to prevent deserialization if required fields are missing

Related Issue

#2114

Checklist

  • The code follows the project's coding standards and is properly linted (npm run lint).
  • Tests have been added or updated to cover the changes.
  • Documentation has been updated to reflect the changes.
  • All tests pass successfully locally.(npm run test).

Additional Notes

github-actions[bot]
github-actions bot reviewed Oct 29, 2024
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

@netlify Netlify
Copy link

netlify bot commented Oct 29, 2024 •
edited
Loading

✅ Deploy Preview for modelina canceled.

Name Link
🔨 Latest commit 836893f
🔍 Latest deploy log https://app.netlify.com/sites/modelina/deploys/6794d56f14cc56000820ab2d

@fr-th fr-th mentioned this pull request Oct 29, 2024
Open
2 tasks
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

jonaslagoni
jonaslagoni approved these changes Oct 29, 2024
View reviewed changes
Copy link
Member

@jonaslagoni jonaslagoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you want to continue with enforceRequired or make it part of the default rendering process?

All you need to make the changes on the next branch instead of master, but up to you 🙂

jonaslagoni
jonaslagoni requested changes Oct 29, 2024
View reviewed changes
Copy link
Member

@jonaslagoni jonaslagoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

** Still need to review 😄

@coveralls
Copy link

coveralls commented Oct 29, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 12964805542

Details

  • 3 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.009%) to 92.312%
Totals Coverage Status
Change from base Build 12963820291: -0.009%
Covered Lines: 6006
Relevant Lines: 6337
💛 - Coveralls

@fr-th fr-th changed the base branch from master to next October 29, 2024 10:50
@fr-th fr-th requested a review from devilkiller-ag as a code owner October 29, 2024 10:50
@fr-th
Copy link
Contributor Author

fr-th commented Oct 29, 2024

Ah damn, I missed the part for the 'next' branch sorry.
I'll adapt

@fr-th fr-th changed the base branch from next to master October 29, 2024 10:56
@jonaslagoni jonaslagoni changed the title feat: #2114 - add required field management in csharp newtonsoft serializer feat: add required field management in csharp newtonsoft serializer Jan 24, 2025
@jonaslagoni jonaslagoni changed the base branch from master to next January 24, 2025 13:53
@jonaslagoni jonaslagoni changed the base branch from next to master January 24, 2025 13:54
@jonaslagoni
Copy link
Member

Lets just do master.

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@jonaslagoni jonaslagoni merged commit 4db3328 into asyncapi:master Jan 25, 2025
16 of 17 checks passed
@jonaslagoni
Copy link
Member

@all-contributors please add @fr-th for code, test, docs

@allcontributors allcontributors bot mentioned this pull request Jan 25, 2025
Merged
@allcontributors AllContributors
Copy link
Contributor

@jonaslagoni

I've put up a pull request to add @fr-th! 🎉

@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 3.11.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@jonaslagoni jonaslagoni jonaslagoni approved these changes

@magicmatatjahu magicmatatjahu Awaiting requested review from magicmatatjahu magicmatatjahu is a code owner

@kennethaasan kennethaasan Awaiting requested review from kennethaasan kennethaasan is a code owner

@asyncapi-bot-eve asyncapi-bot-eve Awaiting requested review from asyncapi-bot-eve asyncapi-bot-eve is a code owner

@devilkiller-ag devilkiller-ag Awaiting requested review from devilkiller-ag

@Samridhi-98 Samridhi-98 Awaiting requested review from Samridhi-98

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fr-th @coveralls @jonaslagoni @asyncapi-bot