fix: fixes union type with discriminator in go #1967
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for modelina canceled.
|
|
jonaslagoni
requested changes
Apr 25, 2024
Comment on lines
+186
to
+189
| if op >= CatType(len(CatTypeValues)) { | ||
| return nil | ||
| } | ||
| return CatTypeValues[op] |
There was a problem hiding this comment.
Think the indentation is incorrect, right? 🤔
There was a problem hiding this comment.
Sure looks like it, but it's not related to this PR I think. I haven't touched enums
jonaslagoni
approved these changes
Apr 25, 2024
|
🎉 This PR is included in version 4.0.0-next.35 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I got some feedback after #1958 was merged. This fixes some issues with the union type with discriminator in go.
Related Issue
Checklist
npm run lint).npm run test).Additional Notes